From 07bfc6164d72c20335ac76ebd58b08b196337afd Mon Sep 17 00:00:00 2001 From: Deepak Majeti Date: Fri, 2 Aug 2024 15:16:55 -0700 Subject: [PATCH] Fix velox_dwio_parquet_reader_benchmark build on Ubuntu (#10648) Summary: Resolves https://github.com/facebookincubator/velox/issues/10323 Pull Request resolved: https://github.com/facebookincubator/velox/pull/10648 Reviewed By: amitkdutta Differential Revision: D60635666 Pulled By: kagamiori fbshipit-source-id: 9be8d5983018c91355fcdef4ebb89113840ec094 --- .github/workflows/linux-build.yml | 2 +- .../dwio/parquet/tests/reader/CMakeLists.txt | 21 +++++-------------- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/.github/workflows/linux-build.yml b/.github/workflows/linux-build.yml index 320c1ba4075f..977b4a269369 100644 --- a/.github/workflows/linux-build.yml +++ b/.github/workflows/linux-build.yml @@ -169,7 +169,7 @@ jobs: env: VELOX_DEPENDENCY_SOURCE: BUNDLED MAKEFLAGS: "NUM_THREADS=8 MAX_HIGH_MEM_JOBS=4 MAX_LINK_JOBS=4" - EXTRA_CMAKE_FLAGS: "-DVELOX_ENABLE_ARROW=ON" + EXTRA_CMAKE_FLAGS: "-DVELOX_ENABLE_ARROW=ON -DVELOX_ENABLE_PARQUET=ON" run: | make debug diff --git a/velox/dwio/parquet/tests/reader/CMakeLists.txt b/velox/dwio/parquet/tests/reader/CMakeLists.txt index 7c0bfa80fdac..e01126e3115f 100644 --- a/velox/dwio/parquet/tests/reader/CMakeLists.txt +++ b/velox/dwio/parquet/tests/reader/CMakeLists.txt @@ -42,22 +42,14 @@ target_link_libraries( velox_exec_test_lib velox_exec velox_hive_connector - Folly::folly + ${TEST_LINK_LIBS} ${FOLLY_BENCHMARK} - ${TEST_LINK_LIBS}) + Folly::folly) add_executable(velox_dwio_parquet_reader_benchmark ParquetReaderBenchmarkMain.cpp) target_link_libraries( - velox_dwio_parquet_reader_benchmark - velox_dwio_parquet_reader_benchmark_lib - velox_dwio_parquet_reader - velox_dwio_parquet_writer - velox_exec_test_lib - velox_exec - velox_hive_connector - Folly::folly - ${TEST_LINK_LIBS}) + velox_dwio_parquet_reader_benchmark velox_dwio_parquet_reader_benchmark_lib) add_executable(velox_dwio_parquet_reader_test ParquetReaderTest.cpp ParquetReaderBenchmarkTest.cpp) @@ -66,11 +58,8 @@ add_test( COMMAND velox_dwio_parquet_reader_test WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}) target_link_libraries( - velox_dwio_parquet_reader_test - velox_dwio_native_parquet_reader - velox_dwio_parquet_reader_benchmark_lib - velox_link_libs - ${TEST_LINK_LIBS}) + velox_dwio_parquet_reader_test velox_dwio_parquet_reader_benchmark_lib + velox_link_libs) add_executable(velox_dwio_parquet_structure_decoder_test NestedStructureDecoderTest.cpp)