From 0cd6c0a02df9679f9a9adcd10304ecca34088551 Mon Sep 17 00:00:00 2001
From: Wei He <weihe@meta.com>
Date: Mon, 18 Mar 2024 18:31:26 -0700
Subject: [PATCH] Update skip function list of AggregationFuzzerTest and
 WindowFuzzerTest (#9138)

Summary:
Pull Request resolved: https://github.com/facebookincubator/velox/pull/9138

Update the skip function list of AggregationFuzzerTest and WindowFuzzerTest so that
they can successfully run for 1 hour. This is needed for setting up nightly job of the fuzzer
tests. Functions in the skip function list will be removed once they are unblocked later.

Reviewed By: kgpai

Differential Revision: D55026943

fbshipit-source-id: 31d90ded24f566ff528d8dd710cd6805ceccfc9a
---
 .../prestosql/fuzzer/AggregationFuzzerTest.cpp       |  5 ++++-
 .../functions/prestosql/fuzzer/WindowFuzzerTest.cpp  | 12 +++++++++---
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/velox/functions/prestosql/fuzzer/AggregationFuzzerTest.cpp b/velox/functions/prestosql/fuzzer/AggregationFuzzerTest.cpp
index c9d6bf137e11..bccc50eebab1 100644
--- a/velox/functions/prestosql/fuzzer/AggregationFuzzerTest.cpp
+++ b/velox/functions/prestosql/fuzzer/AggregationFuzzerTest.cpp
@@ -102,6 +102,8 @@ int main(int argc, char** argv) {
 
   // List of functions that have known bugs that cause crashes or failures.
   static const std::unordered_set<std::string> skipFunctions = {
+      // Skip internal functions used only for result verifications.
+      "$internal$count_distinct",
       // https://github.com/facebookincubator/velox/issues/3493
       "stddev_pop",
       // Lambda functions are not supported yet.
@@ -111,7 +113,8 @@ int main(int argc, char** argv) {
       "approx_set",
       "min_by",
       "max_by",
-      "any_value"};
+      "any_value",
+  };
 
   using facebook::velox::exec::test::ApproxDistinctResultVerifier;
   using facebook::velox::exec::test::ApproxPercentileResultVerifier;
diff --git a/velox/functions/prestosql/fuzzer/WindowFuzzerTest.cpp b/velox/functions/prestosql/fuzzer/WindowFuzzerTest.cpp
index 81cc2c6286c7..05b93084d2c4 100644
--- a/velox/functions/prestosql/fuzzer/WindowFuzzerTest.cpp
+++ b/velox/functions/prestosql/fuzzer/WindowFuzzerTest.cpp
@@ -70,7 +70,7 @@ getCustomInputGenerators() {
 
 int main(int argc, char** argv) {
   facebook::velox::aggregate::prestosql::registerAllAggregateFunctions(
-      "", false);
+      "", false, true);
   facebook::velox::aggregate::prestosql::registerInternalAggregateFunctions("");
   facebook::velox::window::prestosql::registerAllWindowFunctions();
   facebook::velox::functions::prestosql::registerAllScalarFunctions();
@@ -87,12 +87,18 @@ int main(int argc, char** argv) {
 
   // List of functions that have known bugs that cause crashes or failures.
   static const std::unordered_set<std::string> skipFunctions = {
+      // Skip internal functions used only for result verifications.
+      "$internal$count_distinct",
       // https://github.com/facebookincubator/velox/issues/3493
       "stddev_pop",
       // Lambda functions are not supported yet.
       "reduce_agg",
-      // Skip internal functions used only for result verifications.
-      "$internal$count_distinct",
+      // array_agg requires a flag controlling whether to ignore nulls.
+      "array_agg",
+      // min_by and max_by are fixed recently, requiring Presto-0.286.
+      // https://github.com/prestodb/presto/pull/21793
+      "min_by",
+      "max_by",
   };
 
   // Functions whose results verification should be skipped. These can be