-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix LEFT and ANTI joins to preserve probe order (#10832)
Summary: Pull Request resolved: #10832 Currently for LEFT and ANTI joins, when there is a carryover missing row from previous batch, we keep it and add it at end of current batch if there is capacity, which breaks the order of probe side rows. To fix this we simplify the logic of `NoMatchDetector` to emit rows in order. As a result of that, the carryover row will be added as soon as we can decide it needs to be added to output; this means we need to make one row extra space on output buffers for the carryover case. In the same case we also need to use temporary buffers to avoid data being overwritten before we read them. Reviewed By: mbasmanova Differential Revision: D61795406 fbshipit-source-id: 7f972701718fb62d60c7122ee5432f47fec8e241
- Loading branch information
1 parent
d33cdb2
commit 3bf1a74
Showing
4 changed files
with
153 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters