From 63c848d6bd1727f0fe82093c9fc6ad45f87d3ebc Mon Sep 17 00:00:00 2001 From: Christian Zentgraf Date: Tue, 8 Oct 2024 15:39:09 -0700 Subject: [PATCH] Fix arrow install with custom INSTALL_PREFIX (#11052) Summary: If the recently added INSTALL_PREFIX does not point to /usr/local in Linux then the bundled Thrift installation from the Arrow dependency fails because it cannot locate Boost. Boost was previously installed into the INSTALL_PREFIX but the Thrift CMake in Arrow does not pass on any PREFIX_PATH settings to Thrift. The PREFIX_PATH is set to the INSTALL_PREFIX and works with Arrow itself just fine. The error would be Could NOT find Boost (missing: Boost_INCLUDE_DIR) (Required is at least version "1.56") Pull Request resolved: https://github.com/facebookincubator/velox/pull/11052 Reviewed By: bikramSingh91 Differential Revision: D64060501 Pulled By: xiaoxmeng fbshipit-source-id: b393d9d0590828a8473a3f80ebc10d350fd3d20a --- scripts/setup-centos9.sh | 3 ++- scripts/setup-ubuntu.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/setup-centos9.sh b/scripts/setup-centos9.sh index cb193c27c96d..d6b4a0942d02 100755 --- a/scripts/setup-centos9.sh +++ b/scripts/setup-centos9.sh @@ -206,7 +206,8 @@ function install_arrow { -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \ -DCMAKE_BUILD_TYPE=Release \ -DARROW_BUILD_STATIC=ON \ - -DThrift_SOURCE=BUNDLED + -DThrift_SOURCE=BUNDLED \ + -DBOOST_ROOT=${INSTALL_PREFIX} ( # Install thrift. diff --git a/scripts/setup-ubuntu.sh b/scripts/setup-ubuntu.sh index 6ab4daae6b59..6e611b429f4d 100755 --- a/scripts/setup-ubuntu.sh +++ b/scripts/setup-ubuntu.sh @@ -214,7 +214,8 @@ function install_arrow { -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} \ -DCMAKE_BUILD_TYPE=Release \ -DARROW_BUILD_STATIC=ON \ - -DThrift_SOURCE=BUNDLED + -DThrift_SOURCE=BUNDLED \ + -DBOOST_ROOT=${INSTALL_PREFIX} ( # Install thrift.