From 788aa79d42acad401f99da13c49526669a274c48 Mon Sep 17 00:00:00 2001
From: Deepak Majeti <deepak.majeti@ibm.com>
Date: Fri, 1 Mar 2024 12:33:42 +0530
Subject: [PATCH] Improve echo

---
 scripts/setup-centos8.sh | 6 +++---
 scripts/setup-macos.sh   | 3 ++-
 scripts/setup-ubuntu.sh  | 3 ++-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/scripts/setup-centos8.sh b/scripts/setup-centos8.sh
index 6cd172ef75a6e..08c41ccdf59ba 100755
--- a/scripts/setup-centos8.sh
+++ b/scripts/setup-centos8.sh
@@ -213,6 +213,7 @@ function install_velox_deps {
     for cmd in "$@"; do
       run_and_time "${cmd}"
     done
+    echo "All specified dependencies installed!"
   else
     if [ "${INSTALL_PREREQUISITES:-Y}" == "Y" ]; then
       echo "Installing build dependencies"
@@ -222,9 +223,8 @@ function install_velox_deps {
     source /opt/rh/gcc-toolset-9/enable || exit 1
     set -u
     install_velox_deps
+    echo "All dependencies for Velox installed!"
+    dnf clean all
   fi
 )
 
-echo "All dependencies for Velox installed!"
-
-dnf clean all
diff --git a/scripts/setup-macos.sh b/scripts/setup-macos.sh
index 47bff3ab27c07..4a49762d91324 100755
--- a/scripts/setup-macos.sh
+++ b/scripts/setup-macos.sh
@@ -147,15 +147,16 @@ function install_velox_deps {
     for cmd in "$@"; do
       run_and_time "${cmd}"
     done
+    echo "All specified dependencies installed!"
   else
     if [ "${INSTALL_PREREQUISITES:-Y}" == "Y" ]; then
       echo "Installing build dependencies"
       run_and_time install_build_prerequisites
     fi
     install_velox_deps
+    echo "All deps for Velox installed! Now try \"make\""
   fi
 )
 
-echo "All deps for Velox installed! Now try \"make\""
 echo 'To add cmake-format bin to your $PATH, consider adding this to your ~/.profile:'
 echo 'export PATH=$HOME/bin:$HOME/Library/Python/3.7/bin:$PATH'
diff --git a/scripts/setup-ubuntu.sh b/scripts/setup-ubuntu.sh
index 9446d1af14f79..dca2b76834967 100755
--- a/scripts/setup-ubuntu.sh
+++ b/scripts/setup-ubuntu.sh
@@ -154,13 +154,14 @@ function install_velox_deps {
     for cmd in "$@"; do
       run_and_time "${cmd}"
     done
+    echo "All specified dependencies installed!"
   else
     if [ "${INSTALL_PREREQUISITES:-Y}" == "Y" ]; then
       echo "Installing build dependencies"
       run_and_time install_build_prerequisites
     fi
     install_velox_deps
+    echo "All dependencies for Velox installed!"
   fi
 )
 
-echo "All dependencies for Velox installed!"