From 83c2f635c934771081db3f96aa08294d0f93dbf2 Mon Sep 17 00:00:00 2001 From: Patrick Sullivan Date: Thu, 5 Oct 2023 13:09:27 -0700 Subject: [PATCH] List initialize blobStream_ in StringDictionaryColumnReader (#6855) Summary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/6855 Below diffs allow us to add more private members to initialization list. Yay! Reviewed By: Magoja Differential Revision: D49840659 fbshipit-source-id: 42a33d5b55d3be27c33948ced14c9dc79770712c --- velox/dwio/dwrf/reader/ColumnReader.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/velox/dwio/dwrf/reader/ColumnReader.cpp b/velox/dwio/dwrf/reader/ColumnReader.cpp index 0791a019139a..ed9f3e38e963 100644 --- a/velox/dwio/dwrf/reader/ColumnReader.cpp +++ b/velox/dwio/dwrf/reader/ColumnReader.cpp @@ -1149,6 +1149,10 @@ StringDictionaryColumnReader::StringDictionaryColumnReader( dictionaryCount_(stripe.getEncoding(encodingKey).dictionarysize()), lastStrideIndex_(-1), provider_(stripe.getStrideIndexProvider()), + blobStream_(stripe.getStream( + encodingKey.forKind(proto::Stream_Kind_DICTIONARY_DATA), + streamLabels.label(), + false)), returnFlatVector_(stripe.getRowReaderOptions().getReturnFlatVector()) { dictIndex_ = makeRleDecoder( encodingKey, @@ -1168,11 +1172,6 @@ StringDictionaryColumnReader::StringDictionaryColumnReader( proto::Stream_Kind_LENGTH, memoryPool_); - blobStream_ = stripe.getStream( - encodingKey.forKind(proto::Stream_Kind_DICTIONARY_DATA), - streamLabels.label(), - false); - // handle in dictionary stream std::unique_ptr inDictStream = stripe.getStream(