Skip to content

Commit c2fa517

Browse files
rui-mofacebook-github-bot
authored andcommitted
Remove DictEncoder dtor checking in Parquet writer (#10445)
Summary: Below exception is noticed when running spark_aggregation_fuzzer_test with #9559, which writes Velox vectors into Parquet files for Spark to read. ``` velox/dwio/parquet/writer/arrow/Encoding.cpp:513: Check failed: buffered_indices_.empty() ./velox/functions/sparksql/fuzzer/spark_aggregation_fuzzer_test ``` This PR follows apache/arrow@02ad5ae to remove this check. Pull Request resolved: #10445 Reviewed By: kagamiori Differential Revision: D59814851 Pulled By: mbasmanova fbshipit-source-id: a72e6f7608d8bb1763e11e57ef1e5b8daa40f9cf
1 parent 62dca89 commit c2fa517

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

velox/dwio/parquet/writer/arrow/Encoding.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -505,9 +505,7 @@ class DictEncoderImpl : public EncoderImpl, virtual public DictEncoder<DType> {
505505
dict_encoded_size_(0),
506506
memo_table_(pool, kInitialHashTableSize) {}
507507

508-
~DictEncoderImpl() override {
509-
DCHECK(buffered_indices_.empty());
510-
}
508+
~DictEncoderImpl() = default;
511509

512510
int dict_encoded_size() const override {
513511
return dict_encoded_size_;

0 commit comments

Comments
 (0)