Skip to content

Commit

Permalink
Remove DictEncoder dtor checking in Parquet writer (#10445)
Browse files Browse the repository at this point in the history
Summary:
Below exception is noticed when running spark_aggregation_fuzzer_test with
#9559, which writes Velox vectors into Parquet files for Spark to read.

```
velox/dwio/parquet/writer/arrow/Encoding.cpp:513:  Check failed: buffered_indices_.empty()
./velox/functions/sparksql/fuzzer/spark_aggregation_fuzzer_test
```
This PR follows apache/arrow@02ad5ae to remove this check.

Pull Request resolved: #10445

Reviewed By: kagamiori

Differential Revision: D59814851

Pulled By: mbasmanova

fbshipit-source-id: a72e6f7608d8bb1763e11e57ef1e5b8daa40f9cf
  • Loading branch information
rui-mo authored and facebook-github-bot committed Jul 17, 2024
1 parent 62dca89 commit c2fa517
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions velox/dwio/parquet/writer/arrow/Encoding.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -505,9 +505,7 @@ class DictEncoderImpl : public EncoderImpl, virtual public DictEncoder<DType> {
dict_encoded_size_(0),
memo_table_(pool, kInitialHashTableSize) {}

~DictEncoderImpl() override {
DCHECK(buffered_indices_.empty());
}
~DictEncoderImpl() = default;

int dict_encoded_size() const override {
return dict_encoded_size_;
Expand Down

0 comments on commit c2fa517

Please sign in to comment.