From d2122cef145a158c0f26beb683c95cb0738b2447 Mon Sep 17 00:00:00 2001 From: Krishna Pai Date: Tue, 7 Nov 2023 18:48:52 -0800 Subject: [PATCH] Fix call to unsafeResize in StructColumnReader (#7461) Summary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/7461 Ensure call to unsafeResize sets new rows to false in StructColumnReader. When adding unsafeRowApi (D50577808) I missed setting one call to false instead of the default true. Reviewed By: Yuhta Differential Revision: D51091937 fbshipit-source-id: 441ed2b86d81fac6f703dd84f25a95b4e73752c7 --- velox/dwio/dwrf/reader/ColumnReader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/velox/dwio/dwrf/reader/ColumnReader.cpp b/velox/dwio/dwrf/reader/ColumnReader.cpp index 763e4b14adc3..e538a77ac1b7 100644 --- a/velox/dwio/dwrf/reader/ColumnReader.cpp +++ b/velox/dwio/dwrf/reader/ColumnReader.cpp @@ -1864,7 +1864,7 @@ void StructColumnReader::next( DWIO_ENSURE_GE(childrenVectors.size(), children_.size()); // Resize rowVector - rowVector->unsafeResize(numValues); + rowVector->unsafeResize(numValues, false); } BufferPtr nulls = readNulls(numValues, result, incomingNulls);