From d240071223c6bc83391a7b08a7e10250cb0dd3a8 Mon Sep 17 00:00:00 2001
From: Deepak Majeti <deepak.majeti@ibm.com>
Date: Mon, 16 Dec 2024 11:58:57 -0500
Subject: [PATCH] build: Cleanup Hive Connector depenencies

---
 velox/connectors/hive/CMakeLists.txt           | 11 +----------
 velox/connectors/hive/HiveConnector.cpp        |  1 -
 velox/dwio/parquet/tests/writer/CMakeLists.txt |  1 +
 velox/exec/tests/utils/CMakeLists.txt          |  2 ++
 velox/tool/trace/CMakeLists.txt                |  4 ++++
 5 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/velox/connectors/hive/CMakeLists.txt b/velox/connectors/hive/CMakeLists.txt
index 2e137dbd6c29..57f21c0a16a5 100644
--- a/velox/connectors/hive/CMakeLists.txt
+++ b/velox/connectors/hive/CMakeLists.txt
@@ -39,18 +39,9 @@ velox_link_libraries(
     velox_common_io
     velox_connector
     velox_dwio_catalog_fbhive
-    velox_dwio_dwrf_reader
     velox_dwio_dwrf_writer
-    velox_dwio_orc_reader
-    velox_dwio_parquet_reader
     velox_dwio_parquet_writer
-    velox_file
-    velox_hive_partition_function
-    velox_type_tz
-    velox_s3fs
-    velox_hdfs
-    velox_gcs
-    velox_abfs)
+    velox_hive_partition_function)
 
 velox_add_library(velox_hive_partition_function HivePartitionFunction.cpp)
 
diff --git a/velox/connectors/hive/HiveConnector.cpp b/velox/connectors/hive/HiveConnector.cpp
index bf0ff2b07fee..4675764b4292 100644
--- a/velox/connectors/hive/HiveConnector.cpp
+++ b/velox/connectors/hive/HiveConnector.cpp
@@ -27,7 +27,6 @@
 #include <memory>
 
 using namespace facebook::velox::exec;
-using namespace facebook::velox::dwrf;
 
 namespace facebook::velox::connector::hive {
 
diff --git a/velox/dwio/parquet/tests/writer/CMakeLists.txt b/velox/dwio/parquet/tests/writer/CMakeLists.txt
index 01e718dc22c4..93a0538650c7 100644
--- a/velox/dwio/parquet/tests/writer/CMakeLists.txt
+++ b/velox/dwio/parquet/tests/writer/CMakeLists.txt
@@ -41,6 +41,7 @@ add_test(
 target_link_libraries(
   velox_parquet_writer_test
   velox_dwio_parquet_writer
+  velox_dwio_parquet_reader
   velox_dwio_common_test_utils
   velox_link_libs
   Boost::regex
diff --git a/velox/exec/tests/utils/CMakeLists.txt b/velox/exec/tests/utils/CMakeLists.txt
index 0df50966d54b..0013f15b6bcd 100644
--- a/velox/exec/tests/utils/CMakeLists.txt
+++ b/velox/exec/tests/utils/CMakeLists.txt
@@ -46,6 +46,8 @@ target_link_libraries(
   velox_dwio_common
   velox_dwio_dwrf_reader
   velox_dwio_dwrf_writer
+  velox_dwio_parquet_writer
+  velox_dwio_parquet_reader
   velox_dwio_common_test_utils
   velox_file_test_utils
   velox_type_fbhive
diff --git a/velox/tool/trace/CMakeLists.txt b/velox/tool/trace/CMakeLists.txt
index d36ee8fab023..6f4f97999357 100644
--- a/velox/tool/trace/CMakeLists.txt
+++ b/velox/tool/trace/CMakeLists.txt
@@ -34,6 +34,10 @@ target_link_libraries(
   velox_hive_connector
   velox_tpch_connector
   velox_memory
+  velox_hdfs
+  velox_gcs
+  velox_abfs
+  velox_s3fs
   Folly::folly
   glog::glog
   gflags::gflags)