setup-macos.sh failed installing fast_float

[yingsu00]

Problem description

#11018 added install_fast_float, but didn't specify the version by default. The setup failed to download the package.

Create a brand new repo, run scripts/setup-macos.sh

~/repo/velox7/velox/deps-download/fast_float ~/repo/velox7/velox/deps-download ~/repo/velox7/velox
+ curl -L https://github.com/fastfloat/fast_float/archive/refs/tags/.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
^M  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
^M100    20  100    20    0     0     64      0 --:--:-- --:--:-- --:--:--    64
+ tar -xz --strip-components=1 -f fast_float.tar.gz
tar: Error opening archive: Unrecognized archive format
+ popd
~/repo/velox7/velox/deps-download ~/repo/velox7/velox
+ popd
~/repo/velox7/velox
+ cmake_install_dir fast_float
+ pushd /Users/yingsu/repo/velox7/velox/deps-download/fast_float
~/repo/velox7/velox/deps-download/fast_float ~/repo/velox7/velox
+ shift
+ cmake_install
+++ pwd
++ basename /Users/yingsu/repo/velox7/velox/deps-download/fast_float
+ local NAME=fast_float
+ local BINARY_DIR=_build
+ SUDO=
+ '[' -d _build ']'
+ mkdir -p _build
++ get_cxx_flags
++ local CPU_ARCH=
+++ uname
++ local OS=Darwin
+++ uname -m
++ local MACHINE=arm64
++ [[ -z '' ]]
++ '[' Darwin = Darwin ']'
++ '[' arm64 = arm64 ']'
++ CPU_ARCH=arm64
++ case $CPU_ARCH in
++ echo -n '-mcpu=apple-m1+crc -std=c++17 -fvisibility=hidden'
+ COMPILER_FLAGS='-mcpu=apple-m1+crc -std=c++17 -fvisibility=hidden'
+ COMPILER_FLAGS+=' -isystem /opt/homebrew/include '
+ cmake -Wno-dev -B_build -GNinja -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_CXX_STANDARD=17 -DCMAKE_PREFIX_PATH=/Users/yingsu/repo/velox7/velox/deps-install -DCMAKE_INSTALL_PREFIX=/Users/yingsu/repo/velox7/velox/deps-install '-DCMAKE_CXX_FLAGS=-mcpu=apple-m1+crc -std=c++17 -fvisibility=hidden -isystem /opt/homebrew/include ' -DBUILD_TESTING=OFF
CMake Error: The source directory "/Users/yingsu/repo/velox7/velox/deps-download/fast_float" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
+ cmake --build _build
Error: could not load cache
+ echo 'build failed'
build failed
+ exit 1

System information

Velox System Info v0.0.2
Commit: c61a353
CMake Version: 3.30.3
System: Darwin-23.4.0
Arch: arm64
C++ Compiler: /Library/Developer/CommandLineTools/usr/bin/c++
C++ Compiler Version: 15.0.0.15000309
C Compiler: /Library/Developer/CommandLineTools/usr/bin/cc
C Compiler Version: 15.0.0.15000309
CMake Prefix Path: /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr;/opt/homebrew;/usr/local;/usr;/;/opt/homebrew/Cellar/cmake/3.30.3;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local

CMake log

Cloning into 'velox'...
remote: Enumerating objects: 105749, done.
remote: Counting objects: 100% (798/798), done.
remote: Compressing objects: 100% (529/529), done.
remote: Total 105749 (delta 444), reused 470 (delta 269), pack-reused 104951 (from 1)
Receiving objects: 100% (105749/105749), 70.49 MiB | 5.16 MiB/s, done.
Resolving deltas: 100% (80267/80267), done.
From github.com:facebookincubator/velox
 * branch                main       -> FETCH_HEAD
 * [new branch]          main       -> upstream/main
Already up to date.
Everything up-to-date
/Users/yingsu/repo/velox7/velox
++ dirname ./scripts/setup-macos.sh
+ SCRIPTDIR=./scripts
+ export INSTALL_PREFIX=/Users/yingsu/repo/velox7/velox/deps-install
+ INSTALL_PREFIX=/Users/yingsu/repo/velox7/velox/deps-install
+ source ./scripts/setup-helper-functions.sh
+++ pwd
++ DEPENDENCY_DIR=/Users/yingsu/repo/velox7/velox/deps-download
++ OS_CXXFLAGS=
+ PYTHON_VENV=./scripts/../.venv
++ brew --prefix
+ export 'OS_CXXFLAGS= -isystem /opt/homebrew/include '
+ OS_CXXFLAGS=' -isystem /opt/homebrew/include '
++ getconf _NPROCESSORS_ONLN
+ NPROC=10
+ DEPENDENCY_DIR=/Users/yingsu/repo/velox7/velox/deps-download
+ MACOS_VELOX_DEPS='bison flex gflags glog googletest icu4c libevent libsodium lz4 lzo openssl protobuf@21 snappy xz zstd'
+ MACOS_BUILD_DEPS='ninja cmake'
+ FB_OS_VERSION=v2024.09.16.00
+ FMT_VERSION=10.1.1
+ return
+ update_brew
+ DEFAULT_BREW_PATH=/usr/local/bin/brew
++ arch
+ '[' arm64 == arm64 ']'
++ which brew
+ DEFAULT_BREW_PATH=/opt/homebrew/bin/brew
+ BREW_PATH=/opt/homebrew/bin/brew
+ /opt/homebrew/bin/brew update --auto-update --verbose
Checking if we need to fetch /opt/homebrew...
==> Auto-updating Homebrew...
Adjust how often this is run with HOMEBREW_AUTO_UPDATE_SECS or disable with
HOMEBREW_NO_AUTO_UPDATE. Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Fetching /opt/homebrew...
Updating /opt/homebrew...
branch 'master' set up to track 'origin/master'.
Reset branch 'stable'
Current branch stable is up to date.
Checking if we need to fetch formula.jws.json...
Checking if we need to fetch cask.jws.json...
Checking if we need to fetch formula_tap_migrations.jws.json...
Checking if we need to fetch cask_tap_migrations.jws.json...
+ /opt/homebrew/bin/brew developer off
+ [[ 0 -ne 0 ]]
+ '[' N == Y ']'
+ echo 'Skipping installation of build dependencies since INSTALL_PREREQUISITES is not set'
Skipping installation of build dependencies since INSTALL_PREREQUISITES is not set
+ install_velox_deps
+ run_and_time install_velox_deps_from_brew
...skipping...
+ mkdir -p fast_float
+ pushd fast_float
~/repo/velox7/velox/deps-download/fast_float ~/repo/velox7/velox/deps-download ~/repo/velox7/velox
+ curl -L https://github.com/fastfloat/fast_float/archive/refs/tags/.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
^M  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
^M100    20  100    20    0     0     64      0 --:--:-- --:--:-- --:--:--    64
+ tar -xz --strip-components=1 -f fast_float.tar.gz
tar: Error opening archive: Unrecognized archive format
+ popd
~/repo/velox7/velox/deps-download ~/repo/velox7/velox
+ popd
~/repo/velox7/velox
+ cmake_install_dir fast_float
+ pushd /Users/yingsu/repo/velox7/velox/deps-download/fast_float
~/repo/velox7/velox/deps-download/fast_float ~/repo/velox7/velox
+ shift
+ cmake_install
+++ pwd
++ basename /Users/yingsu/repo/velox7/velox/deps-download/fast_float
+ local NAME=fast_float
+ local BINARY_DIR=_build
+ SUDO=
+ '[' -d _build ']'
+ mkdir -p _build
++ get_cxx_flags
++ local CPU_ARCH=
+++ uname
++ local OS=Darwin
+++ uname -m
++ local MACHINE=arm64
++ [[ -z '' ]]
++ '[' Darwin = Darwin ']'
++ '[' arm64 = arm64 ']'
++ CPU_ARCH=arm64
++ case $CPU_ARCH in
++ echo -n '-mcpu=apple-m1+crc -std=c++17 -fvisibility=hidden'
+ COMPILER_FLAGS='-mcpu=apple-m1+crc -std=c++17 -fvisibility=hidden'
+ COMPILER_FLAGS+=' -isystem /opt/homebrew/include '
+ cmake -Wno-dev -B_build -GNinja -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_CXX_STANDARD=17 -DCMAKE_PREFIX_PATH=/Users/yingsu/repo/velox7/velox/deps-install -DCMAKE_INSTALL_PREFIX=/Users/yingsu/repo/velox7/velox/deps-install '-DCMAKE_CXX_FLAGS=-mcpu=apple-m1+crc -std=c++17 -fvisibility=hidden -isystem /opt/homebrew/include ' -DBUILD_TESTING=OFF
CMake Error: The source directory "/Users/yingsu/repo/velox7/velox/deps-download/fast_float" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
+ cmake --build _build
Error: could not load cache
+ echo 'build failed'
build failed
+ exit 1

CMake/resolve_dependency_modules/fast_float.cmake content:

include_guard(GLOBAL)

set(VELOX_FAST_FLOAT_VERSION 6.1.6)
set(VELOX_FAST_FLOAT_BUILD_SHA256_CHECKSUM
    4458aae4b0eb55717968edda42987cabf5f7fc737aee8fede87a70035dba9ab0)
set(VELOX_FAST_FLOAT_SOURCE_URL
    "https://github.com/fastfloat/fast_float/archive/v${VELOX_FAST_FLOAT_VERSION}.tar.gz"
)

resolve_dependency_url(FAST_FLOAT)

message(STATUS "Building fast_float from source")
FetchContent_Declare(
  fast_float
  URL ${VELOX_FAST_FLOAT_SOURCE_URL}
  URL_HASH ${VELOX_FAST_FLOAT_BUILD_SHA256_CHECKSUM})

FetchContent_MakeAvailable(fast_float)
# Folly searches for the header path directly so need to make sure to search in
# the dependency path.
list(APPEND CMAKE_PREFIX_PATH "${fast_float_SOURCE_DIR}")