Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet Int96 timestamp support #11160

Open
kishansairam9 opened this issue Oct 3, 2024 · 0 comments
Open

Parquet Int96 timestamp support #11160

kishansairam9 opened this issue Oct 3, 2024 · 0 comments
Labels
enhancement New feature or request parquet

Comments

@kishansairam9
Copy link

kishansairam9 commented Oct 3, 2024

Bug description

Running a simple regex query on one of our internal tables fails on presto native where as it runs perfectly fine on our Trino setup

select stringcol1, stringcol2 from span_event_view where start_time_millis_ts >= from_unixtime(1727087287) and hour(start_time_millis_ts) = hour(from_unixtime(1727568000)) and regexp_like(stringcol1, 'kishan') limit 10;

what we noticed was that if we use the exact same query and remove regexp_like in filter criteria, it succeeds without any issues

Expected behavior

query succeeds

Actual behavior

VeloxRuntimeError:   Split [Hive: gs://<redacted> 4 - 41192] Task 20241001_110809_00007_4su8m.1.0.0.0 Operator: TableScan[0] 0
    at Unknown.# 0  _ZN8facebook5velox7process10StackTraceC1Ei(Unknown Source)
    at Unknown.# 1  _ZN8facebook5velox14VeloxExceptionC2EPKcmS3_St17basic_string_viewIcSt11char_traitsIcEES7_S7_S7_bNS1_4TypeES7_(Unknown Source)
    at Unknown.# 2  _ZN8facebook5velox6detail14veloxCheckFailINS0_17VeloxRuntimeErrorENS1_22CompileTimeEmptyStringEEEvRKNS1_18VeloxCheckFailArgsET0_(Unknown Source)
    at Unknown.# 3  _ZN8facebook5velox4dwio6common10IntDecoderILb1EE7readIntInEET_v(Unknown Source)
    at Unknown.# 4  _ZN8facebook5velox7parquet10PageReader11callDecoderINS0_4dwio6common13ColumnVisitorInNS0_6common6FilterENS5_15ExtractToReaderELb1EEELi0EEEvPKmRbT_(Unknown Source)
    at Unknown.# 5  _ZN8facebook5velox7parquet10PageReader15readWithVisitorINS0_4dwio6common13ColumnVisitorInNS0_6common6FilterENS5_15ExtractToReaderELb1EEEEEvRT_(Unknown Source)
    at Unknown.# 6  _ZN8facebook5velox4dwio6common28SelectiveIntegerColumnReader10readHelperINS0_7parquet19IntegerColumnReaderENS0_6common6FilterELb1ENS2_15ExtractToReaderEEEvPS8_RKN5folly5RangeIPKiEET2_(Unknown Source)
    at Unknown.# 7  _ZN8facebook5velox7parquet21TimestampColumnReader4readEiRKN5folly5RangeIPKiEEPKm(Unknown Source)
    at Unknown.# 8  _ZN8facebook5velox4dwio6common31SelectiveStructColumnReaderBase4readEiRKN5folly5RangeIPKiEEPKm(Unknown Source)
    at Unknown.# 9  _ZN8facebook5velox4dwio6common31SelectiveStructColumnReaderBase4nextEmRSt10shared_ptrINS0_10BaseVectorEEPKNS2_8MutationE(Unknown Source)
    at Unknown.# 10 _ZN8facebook5velox7parquet16ParquetRowReader4nextEmRSt10shared_ptrINS0_10BaseVectorEEPKNS0_4dwio6common8MutationE(Unknown Source)
    at Unknown.# 11 _ZN8facebook5velox9connector4hive7iceberg18IcebergSplitReader4nextEmRSt10shared_ptrINS0_10BaseVectorEE(Unknown Source)
    at Unknown.# 12 _ZN8facebook5velox9connector4hive14HiveDataSource4nextEmRN5folly10SemiFutureINS4_4UnitEEE(Unknown Source)
    at Unknown.# 13 _ZN8facebook5velox4exec9TableScan9getOutputEv(Unknown Source)
    at Unknown.# 14 _ZZN8facebook5velox4exec6Driver11runInternalERSt10shared_ptrIS2_ERS3_INS1_13BlockingStateEERS3_INS0_9RowVectorEEENKUlvE3_clEv(Unknown Source)
    at Unknown.# 15 _ZN8facebook5velox4exec6Driver11runInternalERSt10shared_ptrIS2_ERS3_INS1_13BlockingStateEERS3_INS0_9RowVectorEE(Unknown Source)
    at Unknown.# 16 _ZN8facebook5velox4exec6Driver3runESt10shared_ptrIS2_E(Unknown Source)
    at Unknown.# 17 _ZN5folly6detail8function5call_IZN8facebook5velox4exec6Driver7enqueueESt10shared_ptrIS6_EEUlvE_Lb1ELb0EvJEEET2_DpT3_RNS1_4DataE(Unknown Source)
    at Unknown.# 18 _ZN5folly6detail8function14FunctionTraitsIFvvEEclEv(Unknown Source)
    at Unknown.# 19 _ZN5folly18ThreadPoolExecutor7runTaskERKSt10shared_ptrINS0_6ThreadEEONS0_4TaskE(Unknown Source)
    at Unknown.# 20 _ZN5folly21CPUThreadPoolExecutor9threadRunESt10shared_ptrINS_18ThreadPoolExecutor6ThreadEE(Unknown Source)
    at Unknown.# 21 _ZSt13__invoke_implIvRMN5folly18ThreadPoolExecutorEFvSt10shared_ptrINS1_6ThreadEEERPS1_JRS4_EET_St21__invoke_memfun_derefOT0_OT1_DpOT2_(Unknown Source)
    at Unknown.# 22 _ZSt8__invokeIRMN5folly18ThreadPoolExecutorEFvSt10shared_ptrINS1_6ThreadEEEJRPS1_RS4_EENSt15__invoke_resultIT_JDpT0_EE4typeEOSC_DpOSD_(Unknown Source)
    at Unknown.# 23 _ZNSt5_BindIFMN5folly18ThreadPoolExecutorEFvSt10shared_ptrINS1_6ThreadEEEPS1_S4_EE6__callIvJEJLm0ELm1EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE(Unknown Source)
    at Unknown.# 24 _ZNSt5_BindIFMN5folly18ThreadPoolExecutorEFvSt10shared_ptrINS1_6ThreadEEEPS1_S4_EEclIJEvEET0_DpOT_(Unknown Source)
    at Unknown.# 25 _ZN5folly6detail8function5call_ISt5_BindIFMNS_18ThreadPoolExecutorEFvSt10shared_ptrINS4_6ThreadEEEPS4_S7_EELb1ELb0EvJEEET2_DpT3_RNS1_4DataE(Unknown Source)
    at Unknown.# 26 0x00000000000dbad4(Unknown Source)
    at Unknown.# 27 start_thread(Unknown Source)
    at Unknown.# 28 __clone3(Unknown Source)

System information

Centos based presto native image with velox at fcc1b1c
Ran on kubernetes with x86 nodes

Reproduction

I have shared two parquet files on which this query is failing to @majetideepak, cannot attach it here on public forum. Please reach out over Presto Slack @Kishan if you would like to investigate this.

@kishansairam9 kishansairam9 added bug Something isn't working triage Newly created issue that needs attention. labels Oct 3, 2024
@Yuhta Yuhta added enhancement New feature or request parquet and removed bug Something isn't working triage Newly created issue that needs attention. labels Oct 3, 2024
@Yuhta Yuhta changed the title using regexp_like operator in presto crashing with VeloxRuntimeError Parquet Int96 timestamp support Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parquet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants