From cbf5aa156ee3bac23f7583c42ce14109869af962 Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Sat, 24 Aug 2024 04:17:17 +0200 Subject: [PATCH 1/3] exclude wall time from plots --- scripts/bm-report/report.qmd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/bm-report/report.qmd b/scripts/bm-report/report.qmd index 9951343deec0..bca541e49841 100644 --- a/scripts/bm-report/report.qmd +++ b/scripts/bm-report/report.qmd @@ -87,7 +87,7 @@ format_tags <- function(x) { ```{r total-graphs} # Filter the data and layout the overview plots times_plot <- results |> - filter(tags.suite == "total", endsWith(tags.source, "time")) |> + filter(tags.suite == "total", endsWith(tags.source, "time"), tags.name != "wall_time") |> mutate( stats.data = lubridate::dseconds(stats.data), tags.name = format_tags(tags.name) From 30090a04c4086c73b9554c23fc4fde0d07b6380f Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Sat, 24 Aug 2024 04:17:30 +0200 Subject: [PATCH 2/3] no longer track wall time --- scripts/build-metrics.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/build-metrics.py b/scripts/build-metrics.py index d172a03708b3..707d81eb6a31 100755 --- a/scripts/build-metrics.py +++ b/scripts/build-metrics.py @@ -95,7 +95,7 @@ def _transform_results(self) -> List[BenchmarkResult]: class NinjaLogAdapter(BenchmarkAdapter): """ Adapter to extract compile and link times from a .ninja_log. - Will calculate aggregates for total, compile, link and wall time. + Will calculate aggregates for total, compile and link time. Suite metadata will be set based on binary ending to object, library or executable. Only files in paths beginning with velox/ will be tracked to avoid dependencies. @@ -135,7 +135,6 @@ def _transform_results(self) -> List[BenchmarkResult]: "link_time": 0, "compile_time": 0, "total_time": 0, - "wall_time": get_epoch(log_lines[-1]) - get_epoch(log_lines[0]), } for line in log_lines: From 89d12b91ce8ce547063f4da575c3edf81845bdbd Mon Sep 17 00:00:00 2001 From: Jacob Wujciak-Jens Date: Sat, 24 Aug 2024 04:20:58 +0200 Subject: [PATCH 3/3] add report files to workflow trigger --- .github/workflows/build-metrics.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-metrics.yml b/.github/workflows/build-metrics.yml index 98766847fa26..2a3285e2f6ac 100644 --- a/.github/workflows/build-metrics.yml +++ b/.github/workflows/build-metrics.yml @@ -18,6 +18,7 @@ on: pull_request: paths: - ".github/workflows/build-metrics.yml" + - "script/bm-report/**" workflow_dispatch: inputs: