From c52ceb4ce385368a5000f5e14444bf62d4fd5508 Mon Sep 17 00:00:00 2001 From: Christian Zentgraf Date: Tue, 29 Oct 2024 14:18:21 -0400 Subject: [PATCH] refactor: Fix deprecated errors when using shared_ptr::unique() After the macOS CommandLineTools SDK15 (with Clang16), the new shared_ptr.h now issues the deprecated warnings for C++17 when using the shared_ptr::unique function. This function is removed for C++20. The solution is to replace the function with the actual implementation using use_count. --- .../common/SelectiveRepeatedColumnReader.cpp | 2 +- .../dwio/common/SelectiveStructColumnReader.cpp | 8 ++++---- velox/dwio/common/SelectiveStructColumnReader.h | 2 +- velox/exec/AssignUniqueId.cpp | 2 +- velox/exec/GroupingSet.cpp | 4 ++-- velox/exec/HashProbe.cpp | 4 ++-- velox/exec/MarkDistinct.cpp | 2 +- velox/exec/OutputBuffer.cpp | 2 +- velox/exec/RowNumber.cpp | 2 +- velox/expression/ConstantExpr.cpp | 4 ++-- velox/expression/EvalCtx.cpp | 4 ++-- velox/expression/SimpleFunctionAdapter.h | 2 +- velox/expression/TryExpr.cpp | 2 +- velox/expression/tests/ExprTest.cpp | 10 +++++----- velox/functions/prestosql/VectorArithmetic.cpp | 6 ++++-- velox/serializers/PrestoSerializer.cpp | 6 +++--- velox/vector/BaseVector.cpp | 4 ++-- velox/vector/BaseVector.h | 2 +- velox/vector/ComplexVector.cpp | 4 ++-- velox/vector/VectorPool.cpp | 2 +- velox/vector/tests/EnsureWritableVectorTest.cpp | 16 ++++++++-------- velox/vector/tests/VectorTest.cpp | 6 +++--- 22 files changed, 49 insertions(+), 47 deletions(-) diff --git a/velox/dwio/common/SelectiveRepeatedColumnReader.cpp b/velox/dwio/common/SelectiveRepeatedColumnReader.cpp index 00cea8c1cffb..fa5b546c107a 100644 --- a/velox/dwio/common/SelectiveRepeatedColumnReader.cpp +++ b/velox/dwio/common/SelectiveRepeatedColumnReader.cpp @@ -63,7 +63,7 @@ void prepareResult( result->encoding() == VectorEncoding::Simple::ARRAY) || (type->kind() == TypeKind::MAP && result->encoding() == VectorEncoding::Simple::MAP)) && - result.unique())) { + result.use_count() == 1)) { VLOG(1) << "Reallocating result " << type->kind() << " vector of size " << size; result = BaseVector::create(type, size, pool); diff --git a/velox/dwio/common/SelectiveStructColumnReader.cpp b/velox/dwio/common/SelectiveStructColumnReader.cpp index e3bdf614af2a..dba62caa0322 100644 --- a/velox/dwio/common/SelectiveStructColumnReader.cpp +++ b/velox/dwio/common/SelectiveStructColumnReader.cpp @@ -54,7 +54,7 @@ void fillRowVectorChildren( } VectorPtr tryReuseResult(const VectorPtr& result) { - if (!result.unique()) { + if (result.use_count() != 1) { return nullptr; } switch (result->encoding()) { @@ -99,7 +99,7 @@ void setConstantField( const VectorPtr& constant, vector_size_t size, VectorPtr& field) { - if (field && field->isConstantEncoding() && field.unique() && + if (field && field->isConstantEncoding() && field.use_count() == 1 && field->size() > 0 && field->equalValueAt(constant.get(), 0, 0)) { field->resize(size); } else { @@ -112,7 +112,7 @@ void setNullField( VectorPtr& field, const TypePtr& type, memory::MemoryPool* pool) { - if (field && field->isConstantEncoding() && field.unique() && + if (field && field->isConstantEncoding() && field.use_count() == 1 && field->size() > 0 && field->isNullAt(0)) { field->resize(size); } else { @@ -512,7 +512,7 @@ void SelectiveStructColumnReaderBase::getValues( } auto lazyLoader = std::make_unique(this, children_[index], numReads_); - if (childResult && childResult->isLazy() && childResult.unique()) { + if (childResult && childResult->isLazy() && childResult.use_count() == 1) { static_cast(*childResult) .reset(std::move(lazyLoader), rows.size()); } else { diff --git a/velox/dwio/common/SelectiveStructColumnReader.h b/velox/dwio/common/SelectiveStructColumnReader.h index 17d98815c015..8b95a68385ee 100644 --- a/velox/dwio/common/SelectiveStructColumnReader.h +++ b/velox/dwio/common/SelectiveStructColumnReader.h @@ -227,7 +227,7 @@ class SelectiveFlatMapColumnReaderHelper { private: MapVector& prepareResult(VectorPtr& result, vector_size_t size) { if (result && result->encoding() == VectorEncoding::Simple::MAP && - result.unique()) { + result.use_count() == 1) { result->resetDataDependentFlags(nullptr); result->resize(size); } else { diff --git a/velox/exec/AssignUniqueId.cpp b/velox/exec/AssignUniqueId.cpp index 711796985489..cef60e4f6e60 100644 --- a/velox/exec/AssignUniqueId.cpp +++ b/velox/exec/AssignUniqueId.cpp @@ -76,7 +76,7 @@ bool AssignUniqueId::isFinished() { void AssignUniqueId::generateIdColumn(vector_size_t size) { // Re-use memory for the ID vector if possible. VectorPtr& result = results_[0]; - if (result && result.unique()) { + if (result && result.use_count() == 1) { BaseVector::prepareForReuse(result, size); } else { result = BaseVector::create(BIGINT(), size, pool()); diff --git a/velox/exec/GroupingSet.cpp b/velox/exec/GroupingSet.cpp index 9a015bb2dc22..31d1d3e2ad0d 100644 --- a/velox/exec/GroupingSet.cpp +++ b/velox/exec/GroupingSet.cpp @@ -1291,7 +1291,7 @@ namespace { // Recursive resize all children. void recursiveResizeChildren(VectorPtr& vector, vector_size_t newSize) { - VELOX_CHECK(vector.unique()); + VELOX_CHECK_EQ(vector.use_count(), 1); if (vector->typeKind() == TypeKind::ROW) { auto rowVector = vector->asUnchecked(); for (auto& child : rowVector->children()) { @@ -1307,7 +1307,7 @@ void GroupingSet::toIntermediate( const RowVectorPtr& input, RowVectorPtr& result) { VELOX_CHECK(abandonedPartialAggregation_); - VELOX_CHECK(result.unique()); + VELOX_CHECK_EQ(result.use_count(), 1); if (!isRawInput_) { result = input; return; diff --git a/velox/exec/HashProbe.cpp b/velox/exec/HashProbe.cpp index 820ee839c876..eea99fb13d51 100644 --- a/velox/exec/HashProbe.cpp +++ b/velox/exec/HashProbe.cpp @@ -858,7 +858,7 @@ RowVectorPtr HashProbe::getBuildSideOutput() { } void HashProbe::clearIdentityProjectedOutput() { - if (!output_ || !output_.unique()) { + if (!output_ || output_.use_count() != 1) { return; } for (auto& projection : identityProjections_) { @@ -1212,7 +1212,7 @@ const uint64_t* getFlatFilterResult(VectorPtr& result) { if (!flat->rawValues()) { return flat->rawNulls(); } - if (!result.unique()) { + if (result.use_count() != 1) { return nullptr; } auto* values = flat->mutableRawValues(); diff --git a/velox/exec/MarkDistinct.cpp b/velox/exec/MarkDistinct.cpp index 13222a80c250..8b4d0c09e55c 100644 --- a/velox/exec/MarkDistinct.cpp +++ b/velox/exec/MarkDistinct.cpp @@ -66,7 +66,7 @@ RowVectorPtr MarkDistinct::getOutput() { auto outputSize = input_->size(); // Re-use memory for the ID vector if possible. VectorPtr& result = results_[0]; - if (result && result.unique()) { + if (result && result.use_count() == 1) { BaseVector::prepareForReuse(result, outputSize); } else { result = BaseVector::create(BOOLEAN(), outputSize, operatorCtx_->pool()); diff --git a/velox/exec/OutputBuffer.cpp b/velox/exec/OutputBuffer.cpp index d35325b3c390..bc10d517e01b 100644 --- a/velox/exec/OutputBuffer.cpp +++ b/velox/exec/OutputBuffer.cpp @@ -649,7 +649,7 @@ void OutputBuffer::updateAfterAcknowledgeLocked( uint64_t freedBytes{0}; int freedPages{0}; for (const auto& free : freed) { - if (free.unique()) { + if (free.use_count() == 1) { ++freedPages; freedBytes += free->size(); } diff --git a/velox/exec/RowNumber.cpp b/velox/exec/RowNumber.cpp index 3c4429d9156f..176d518b8ce1 100644 --- a/velox/exec/RowNumber.cpp +++ b/velox/exec/RowNumber.cpp @@ -244,7 +244,7 @@ void RowNumber::ensureInputFits(const RowVectorPtr& input) { FlatVector& RowNumber::getOrCreateRowNumberVector(vector_size_t size) { VectorPtr& result = results_[0]; - if (result && result.unique()) { + if (result && result.use_count() == 1) { BaseVector::prepareForReuse(result, size); } else { result = BaseVector::create(BIGINT(), size, pool()); diff --git a/velox/expression/ConstantExpr.cpp b/velox/expression/ConstantExpr.cpp index f0b618c2e1f9..397699644f84 100644 --- a/velox/expression/ConstantExpr.cpp +++ b/velox/expression/ConstantExpr.cpp @@ -21,7 +21,7 @@ void ConstantExpr::evalSpecialForm( const SelectivityVector& rows, EvalCtx& context, VectorPtr& result) { - if (sharedConstantValue_.unique()) { + if (sharedConstantValue_.use_count() == 1) { sharedConstantValue_->resize(rows.end()); } else { // By reassigning sharedConstantValue_ we increase the chances that it will @@ -33,7 +33,7 @@ void ConstantExpr::evalSpecialForm( if (needToSetIsAscii_) { // sharedConstantValue_ must be unique because computeAndSetIsAscii may // modify it. - VELOX_CHECK(sharedConstantValue_.unique()); + VELOX_CHECK_EQ(sharedConstantValue_.use_count(), 1); auto* vector = sharedConstantValue_->asUnchecked>(); LocalSingleRow singleRow(context, 0); diff --git a/velox/expression/EvalCtx.cpp b/velox/expression/EvalCtx.cpp index 0dd39ab9ce3a..f380daa59fa5 100644 --- a/velox/expression/EvalCtx.cpp +++ b/velox/expression/EvalCtx.cpp @@ -377,7 +377,7 @@ void EvalCtx::addNulls( // or do nothing otherwise. if (result->isConstantEncoding() && result->isNullAt(0)) { if (result->size() < rows.end()) { - if (result.unique()) { + if (result.use_count() == 1) { result->resize(rows.end()); } else { result = @@ -389,7 +389,7 @@ void EvalCtx::addNulls( auto currentSize = result->size(); auto targetSize = rows.end(); - if (!result.unique() || !result->isNullsWritable()) { + if (result.use_count() != 1 || !result->isNullsWritable()) { if (result->type()->isPrimitiveType()) { if (currentSize < targetSize) { resizePrimitiveTypeVectors(result, targetSize, context); diff --git a/velox/expression/SimpleFunctionAdapter.h b/velox/expression/SimpleFunctionAdapter.h index 1f76806d7b73..aa19c249291e 100644 --- a/velox/expression/SimpleFunctionAdapter.h +++ b/velox/expression/SimpleFunctionAdapter.h @@ -285,7 +285,7 @@ class SimpleFunctionAdapter : public VectorFunction { !providesCustomComparison>::value) { using type = typename VectorExec::template resolver>::in_type; - if (args[POSITION]->isFlatEncoding() && args[POSITION].unique() && + if (args[POSITION]->isFlatEncoding() && args[POSITION].use_count() == 1 && args[POSITION]->asUnchecked>()->isWritable()) { // Re-use arg for result. We rely on the fact that for each row // we read arguments before computing and writing out the diff --git a/velox/expression/TryExpr.cpp b/velox/expression/TryExpr.cpp index d8069e1abe1d..174947c3abd2 100644 --- a/velox/expression/TryExpr.cpp +++ b/velox/expression/TryExpr.cpp @@ -141,7 +141,7 @@ void TryExpr::nullOutErrors( auto indices = allocateIndices(size, context.pool()); result = BaseVector::wrapInDictionary(nulls, indices, size, result); } else if ( - result.unique() && result->isNullsWritable() && + result.use_count() == 1 && result->isNullsWritable() && result->size() >= rows.end()) { auto* rawNulls = result->mutableRawNulls(); rows.applyToSelected([&](auto row) { diff --git a/velox/expression/tests/ExprTest.cpp b/velox/expression/tests/ExprTest.cpp index 38738a315c6b..507c75853f5d 100644 --- a/velox/expression/tests/ExprTest.cpp +++ b/velox/expression/tests/ExprTest.cpp @@ -2114,14 +2114,14 @@ TEST_F(ExprTest, memo) { 100, [](auto row) { return (8 + row * 2) % 3 == 1; }); assertEqualVectors(expectedResult, result); VELOX_CHECK_EQ(stats["eq"].numProcessedRows, 100); - VELOX_CHECK(base.unique()); + VELOX_CHECK_EQ(base.use_count(), 1); // After this results would be cached std::tie(result, stats) = evaluateWithStats( exprSet.get(), makeRowVector({wrapInDictionary(evenIndices, 100, base)})); assertEqualVectors(expectedResult, result); VELOX_CHECK_EQ(stats["eq"].numProcessedRows, 200); - VELOX_CHECK(!base.unique()); + VELOX_CHECK_NE(base.use_count(), 1); // Unevaluated rows are processed std::tie(result, stats) = evaluateWithStats( @@ -2130,7 +2130,7 @@ TEST_F(ExprTest, memo) { 100, [](auto row) { return (9 + row * 2) % 3 == 1; }); assertEqualVectors(expectedResult, result); VELOX_CHECK_EQ(stats["eq"].numProcessedRows, 300); - VELOX_CHECK(!base.unique()); + VELOX_CHECK_NE(base.use_count(), 1); auto everyFifth = makeIndices(100, [](auto row) { return row * 5; }); std::tie(result, stats) = evaluateWithStats( @@ -2142,7 +2142,7 @@ TEST_F(ExprTest, memo) { stats["eq"].numProcessedRows, 360, "Fewer rows expected as memoization should have kicked in."); - VELOX_CHECK(!base.unique()); + VELOX_CHECK_NE(base.use_count(), 1); // Create a new base base = makeArrayVector( @@ -2156,7 +2156,7 @@ TEST_F(ExprTest, memo) { 100, [](auto row) { return (9 + row * 2) % 3 == 1; }); assertEqualVectors(expectedResult, result); VELOX_CHECK_EQ(stats["eq"].numProcessedRows, 460); - VELOX_CHECK(base.unique()); + VELOX_CHECK_EQ(base.use_count(), 1); } // This test triggers the situation when peelEncodings() produces an empty diff --git a/velox/functions/prestosql/VectorArithmetic.cpp b/velox/functions/prestosql/VectorArithmetic.cpp index 39a21eada383..b7ad76f7f729 100644 --- a/velox/functions/prestosql/VectorArithmetic.cpp +++ b/velox/functions/prestosql/VectorArithmetic.cpp @@ -132,11 +132,13 @@ class VectorArithmetic : public VectorFunction { // (2) the input type must match the output vector type // (3) usually we try to reuse inputs with flat encoding if (!result) { - if (args[0].unique() && leftEncoding == VectorEncoding::Simple::FLAT) { + if (args[0].use_count() == 1 && + leftEncoding == VectorEncoding::Simple::FLAT) { result = std::move(args[0]); } else if ( - args[1].unique() && rightEncoding == VectorEncoding::Simple::FLAT) { + args[1].use_count() == 1 && + rightEncoding == VectorEncoding::Simple::FLAT) { result = std::move(args[1]); } else { result = BaseVector::create(outputType, rows.end(), context.pool()); diff --git a/velox/serializers/PrestoSerializer.cpp b/velox/serializers/PrestoSerializer.cpp index f59ed0819e3c..952bfa2061b9 100644 --- a/velox/serializers/PrestoSerializer.cpp +++ b/velox/serializers/PrestoSerializer.cpp @@ -4201,9 +4201,9 @@ void PrestoVectorSerde::deserialize( if (resultOffset > 0) { VELOX_CHECK_NOT_NULL(*result); - VELOX_CHECK(result->unique()); + VELOX_CHECK_EQ(result->use_count(), 1); (*result)->resize(resultOffset + header.numRows); - } else if (*result && result->unique()) { + } else if (*result && result->use_count() == 1) { VELOX_CHECK( *(*result)->type() == *type, "Unexpected type: {} vs. {}", @@ -4245,7 +4245,7 @@ void PrestoVectorSerde::deserializeSingleColumn( VELOX_CHECK_EQ( prestoOptions.compressionKind, common::CompressionKind::CompressionKind_NONE); - if (*result && result->unique()) { + if (*result && result->use_count() == 1) { VELOX_CHECK( *(*result)->type() == *type, "Unexpected type: {} vs. {}", diff --git a/velox/vector/BaseVector.cpp b/velox/vector/BaseVector.cpp index 08ecc69f167c..cc98fc2af95b 100644 --- a/velox/vector/BaseVector.cpp +++ b/velox/vector/BaseVector.cpp @@ -601,7 +601,7 @@ void BaseVector::ensureWritable( if (result->encoding() == VectorEncoding::Simple::LAZY) { result = BaseVector::loadedVectorShared(result); } - if (result.unique() && !isUnknownType) { + if (result.use_count() == 1 && !isUnknownType) { switch (result->encoding()) { case VectorEncoding::Simple::FLAT: case VectorEncoding::Simple::ROW: @@ -879,7 +879,7 @@ void BaseVector::flattenVector(VectorPtr& vector) { } void BaseVector::prepareForReuse(VectorPtr& vector, vector_size_t size) { - if (!vector.unique() || !isReusableEncoding(vector->encoding())) { + if (vector.use_count() != 1 || !isReusableEncoding(vector->encoding())) { vector = BaseVector::create(vector->type(), size, vector->pool()); return; } diff --git a/velox/vector/BaseVector.h b/velox/vector/BaseVector.h index ec9ce0a0d883..23b9dc7b8f01 100644 --- a/velox/vector/BaseVector.h +++ b/velox/vector/BaseVector.h @@ -615,7 +615,7 @@ class BaseVector { /// unique. template static bool isVectorWritable(const std::shared_ptr& vector) { - if (!vector.unique()) { + if (vector.use_count() != 1) { return false; } diff --git a/velox/vector/ComplexVector.cpp b/velox/vector/ComplexVector.cpp index 0a4e9c94e3f1..4336aee32bdd 100644 --- a/velox/vector/ComplexVector.cpp +++ b/velox/vector/ComplexVector.cpp @@ -673,7 +673,7 @@ void RowVector::resize(vector_size_t newSize, bool setNotNull) { // to skip uniqueness check since effectively we are just changing // the length. if (newSize > oldSize) { - VELOX_CHECK(child.unique(), "Resizing shared child vector"); + VELOX_CHECK_EQ(child.use_count(), 1, "Resizing shared child vector"); child->resize(newSize, setNotNull); } } @@ -1328,7 +1328,7 @@ void MapVector::canonicalize( // threads. The keys and values do not have to be uniquely owned // since they are not mutated but rather transposed, which is // non-destructive. - VELOX_CHECK(map.unique()); + VELOX_CHECK(map.use_count() == 1); BufferPtr indices; vector_size_t* indicesRange; for (auto i = 0; i < map->BaseVector::length_; ++i) { diff --git a/velox/vector/VectorPool.cpp b/velox/vector/VectorPool.cpp index 5eafdb339bbd..0e4adef8e5b1 100644 --- a/velox/vector/VectorPool.cpp +++ b/velox/vector/VectorPool.cpp @@ -61,7 +61,7 @@ bool VectorPool::release(VectorPtr& vector) { if (FOLLY_UNLIKELY(vector == nullptr)) { return false; } - if (!vector.unique() || vector->size() > kMaxRecycleSize) { + if (vector.use_count() != 1 || vector->size() > kMaxRecycleSize) { return false; } diff --git a/velox/vector/tests/EnsureWritableVectorTest.cpp b/velox/vector/tests/EnsureWritableVectorTest.cpp index 26cd065b7b5e..a86dfae66bb5 100644 --- a/velox/vector/tests/EnsureWritableVectorTest.cpp +++ b/velox/vector/tests/EnsureWritableVectorTest.cpp @@ -241,7 +241,7 @@ struct VectorPointersBase { } void assertUnique(const VectorPtr& vector) { - ASSERT_TRUE(vector.unique()); + ASSERT_EQ(vector.use_count(), 1); auto* typedVector = vector->as(); ASSERT_EQ(nullsUnique, typedVector->nulls()->unique()); @@ -299,7 +299,7 @@ struct ArrayVectorPointers : public VectorPointersBase { VectorPointersBase::assertUnique(vector); auto* arrayVector = vector->as(); - ASSERT_EQ(elementsUnique, arrayVector->elements().unique()); + ASSERT_EQ(elementsUnique, (arrayVector->elements().use_count() == 1)); } void assertPointers(const VectorPtr& vector) { @@ -338,8 +338,8 @@ struct MapVectorPointers : public VectorPointersBase { VectorPointersBase::assertUnique(vector); auto* mapVector = vector->as(); - ASSERT_EQ(keysUnique, mapVector->mapKeys().unique()); - ASSERT_EQ(valuesUnique, mapVector->mapValues().unique()); + ASSERT_EQ(keysUnique, (mapVector->mapKeys().use_count() == 1)); + ASSERT_EQ(valuesUnique, (mapVector->mapValues().use_count() == 1)); } void assertPointers(const VectorPtr& vector) { @@ -476,11 +476,11 @@ TEST_F(EnsureWritableVectorTest, array) { // Multiply-referenced vector auto resultCopy = result; - ASSERT_FALSE(result.unique()); + ASSERT_FALSE(result.use_count() == 1); auto oddRows = selectOddRows(size); BaseVector::ensureWritable(oddRows, result->type(), pool(), result); - ASSERT_TRUE(result.unique()); + ASSERT_TRUE(result.use_count() == 1); ASSERT_NE(resultCopy.get(), result.get()); // Verify that even rows were copied over @@ -601,11 +601,11 @@ TEST_F(EnsureWritableVectorTest, map) { // Multiply-referenced vector auto resultCopy = result; - ASSERT_FALSE(result.unique()); + ASSERT_FALSE(result.use_count() == 1); auto oddRows = selectOddRows(size); BaseVector::ensureWritable(oddRows, result->type(), pool(), result); - ASSERT_TRUE(result.unique()); + ASSERT_TRUE(result.use_count() == 1); ASSERT_NE(resultCopy.get(), result.get()); // Verify that even rows were copied over diff --git a/velox/vector/tests/VectorTest.cpp b/velox/vector/tests/VectorTest.cpp index 3a5525412b02..b61f77f53277 100644 --- a/velox/vector/tests/VectorTest.cpp +++ b/velox/vector/tests/VectorTest.cpp @@ -1549,7 +1549,7 @@ TEST_F(VectorTest, wrapInConstantWithCopy) { std::dynamic_pointer_cast>( BaseVector::wrapInConstant(size, 22, constBaseVector, true)); EXPECT_NE(constArrayVector->valueVector(), nullptr); - EXPECT_TRUE(constArrayVector->valueVector().unique()); + EXPECT_EQ(constArrayVector->valueVector().use_count(), 1); for (auto i = 0; i < size; i++) { ASSERT_FALSE(constArrayVector->isNullAt(i)); ASSERT_TRUE(constArrayVector->equalValueAt(arrayVector.get(), i, 3)); @@ -1561,7 +1561,7 @@ TEST_F(VectorTest, wrapInConstantWithCopy) { constArrayVector = std::dynamic_pointer_cast>( BaseVector::wrapInConstant(size, 22, constBaseVector, true)); EXPECT_NE(constArrayVector->valueVector(), nullptr); - EXPECT_TRUE(constArrayVector->valueVector().unique()); + EXPECT_EQ(constArrayVector->valueVector().use_count(), 1); for (auto i = 0; i < size; i++) { ASSERT_TRUE(constArrayVector->isNullAt(i)); } @@ -1571,7 +1571,7 @@ TEST_F(VectorTest, rowResize) { auto testRowResize = [&](const VectorPtr& vector, bool setNotNull) { auto rowVector = vector->as(); for (auto& child : rowVector->children()) { - VELOX_CHECK(child.unique()); + VELOX_CHECK_EQ(child.use_count(), 1); } auto oldSize = rowVector->size(); auto newSize = oldSize * 2;