Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor presto function base64 to make use of the new utility file #8651

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Refactor presto function base64 to make use of the new utility file #8651

wants to merge 7 commits into from

Conversation

Joe-Abraham
Copy link
Contributor

@Joe-Abraham Joe-Abraham commented Feb 2, 2024 •
edited
Loading

Refactor presto function base64 to make use of the new utility file

Dependencies

  1. refactor: Create utility file for encoding #8650
  2. Fix from_base64 Presto function for inputs without padding #8647

@netlify Netlify
Copy link

netlify bot commented Feb 2, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit c01a22e
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67109aedf4df890008b66af1

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 2, 2024
This was referenced Feb 2, 2024
Open
Open
czentgr
czentgr reviewed Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good.

velox/common/encode/Base64.cpp Outdated Show resolved Hide resolved
velox/common/encode/Base64.cpp Outdated Show resolved Hide resolved
@Joe-Abraham Joe-Abraham force-pushed the refactor branch 2 times, most recently from 4136698 to 796612f Compare March 11, 2024 08:10
@Joe-Abraham Joe-Abraham marked this pull request as draft March 15, 2024 08:00
@Joe-Abraham Joe-Abraham mentioned this pull request Mar 18, 2024
Closed
@Joe-Abraham Joe-Abraham force-pushed the refactor branch 3 times, most recently from 4368134 to 8bb2ab9 Compare March 25, 2024 13:13
czentgr
czentgr reviewed Mar 25, 2024
View reviewed changes
velox/common/encode/CMakeLists.txt Outdated Show resolved Hide resolved
velox/common/encode/tests/CMakeLists.txt Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/tests/Base64Test.cpp Outdated Show resolved Hide resolved
velox/common/encode/tests/Base64Test.cpp Outdated Show resolved Hide resolved
@Joe-Abraham Joe-Abraham force-pushed the refactor branch 4 times, most recently from 47328a1 to 109c7cb Compare April 4, 2024 05:51
@Joe-Abraham Joe-Abraham force-pushed the refactor branch 3 times, most recently from a3d36c7 to feef283 Compare May 7, 2024 04:45
@stale Stale
Copy link

stale bot commented Aug 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

@stale stale bot added the stale label Aug 5, 2024
@stale stale bot removed the stale label Aug 7, 2024
czentgr
czentgr reviewed Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I saw a few things missed earlier.
Once complete we can mark as for review and get additional feedback.

velox/common/encode/tests/Base64Test.cpp Outdated Show resolved Hide resolved
velox/common/encode/tests/EncoderUtilsTests.cpp Outdated Show resolved Hide resolved
velox/common/encode/tests/EncoderUtilsTests.cpp Outdated Show resolved Hide resolved
@Joe-Abraham Joe-Abraham force-pushed the refactor branch 2 times, most recently from 2a714ea to 8b8b9e1 Compare August 13, 2024 09:19
@Joe-Abraham Joe-Abraham force-pushed the refactor branch 5 times, most recently from 1b6b7b2 to 683dcac Compare September 20, 2024 10:48
@Joe-Abraham Joe-Abraham force-pushed the refactor branch 3 times, most recently from e3f7f9b to 118c918 Compare September 27, 2024 12:06
@Joe-Abraham Joe-Abraham force-pushed the refactor branch 4 times, most recently from 1b59b4b to cecd6ec Compare October 5, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czentgr czentgr czentgr left review comments

@assignUser assignUser Awaiting requested review from assignUser assignUser will be requested when the pull request is marked ready for review assignUser is a code owner

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak will be requested when the pull request is marked ready for review majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joe-Abraham @czentgr @facebook-github-bot