Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #type: ignore comments from codebase #367

Open
crasanders opened this issue Jul 29, 2024 · 0 comments
Open

Remove #type: ignore comments from codebase #367

crasanders opened this issue Jul 29, 2024 · 0 comments

Comments

@crasanders
Copy link
Contributor

There are a few instances in the code where mypy is unhappy and we have added #type: ignore comments to bypass the issue rather than fix the underlying error. We should remove these and implement proper type hinting where possible. There may be instances where trying to accommodate mypy is impossible or more cumbersome than just leaving in the #type: ignore comments, but in these instances we should add comments explaining why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant