Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for message decryption #370

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

arnavsacheti
Copy link
Contributor

Differential Revision: D37838812

Arnav Sacheti added 13 commits July 14, 2022 11:52
Summary:
Pull Request resolved: facebookresearch#359

# Context
Want to move s3 i/o out of attestation service.
# This commit
Creates tooling that would enable move to happen, and changes checksum path to follow styling of repository path for simplicity

Differential Revision: D37524841

fbshipit-source-id: ec1b84be5456c8340b8c3d8b1747dfc1e24e7085
Summary: Added functionalilty to upload in last commit, this extends this to also include downloading of checksum file

Differential Revision: D37525237

fbshipit-source-id: 45ee1e3d3ad437f9aea39f6b5f6612f91428c76d
Summary:
Pull Request resolved: facebookresearch#360

# Context
We added functionality to upload checksums to ODPR, but dont use it atm.
# This commit
Removes the uploading from AttestationService and puts it into ODPR.

Differential Revision: D37526228

fbshipit-source-id: 3f12457300792b9c5a93e182efbcf7a40054722a
Summary:
# Context
Want to move all s3 i/o out of AttestationService
# This Commit
Moves download from AttestationService to ODPR

Differential Revision: D37526823

fbshipit-source-id: ce810ae53fce9af4b5bd5d364376f819b5524226
Differential Revision: D37566562

fbshipit-source-id: 76271b94c30e6bd28a0091175c5c1b129a0ea8d0
Summary: Just adding some logs to help clean up output

Differential Revision: D37527124

fbshipit-source-id: 20b074fcb8419ee416860cdbf33fa5ce24ca7339
Summary:
Pull Request resolved: facebookresearch#344

# Context
What good is integration if no easy way to interact when running program from CLI
# This commit
Adds default and env variable lookup allowing run from CLI

Differential Revision: D37229577

fbshipit-source-id: 625101ea81d22dce2423cd7811e360c8d9f125fd
Summary:
Pull Request resolved: facebookresearch#331

# Context
Now that all the tooling should be done, we want some more comprehensive tests to check everything works as it should

# This commit
Adds many tests both through s3 and locally to verify that code is working as it should

Differential Revision: D36839896

fbshipit-source-id: 70e1905e28b8b538dc99fec1086097072b0badde
Differential Revision: D37400919

fbshipit-source-id: f52e3b40b40b1d6847c8f414384372a7403c26f0
Differential Revision: https://www.internalfb.com/diff/D37403863?entry_point=27

fbshipit-source-id: 0647c6f4c042dac2a0d6645dec324609a3b8f668
Differential Revision: D37838138

fbshipit-source-id: 7a9e7c044eb1c11b7bafbd451301a956aaba3e85
Differential Revision: D37667144

fbshipit-source-id: 265dd629bd4f9111109b19e8f887d7c733823f21
Differential Revision: D37838812

fbshipit-source-id: aebac3c09bff8cbae49fca104b1e659d6b6f173f
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 14, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37838812

@facebook-github-bot
Copy link
Contributor

Hi @IamStegoMan!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants