-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass server_uris in when creating MPCInstance #459
Open
YigeZhu
wants to merge
1
commit into
facebookresearch:main
Choose a base branch
from
YigeZhu:export-D40997128
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Nov 4, 2022
This pull request was exported from Phabricator. Differential Revision: D40997128 |
YigeZhu
added a commit
to YigeZhu/fbpcp
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: facebookresearch#459 As title. server_uris will be passed into MPCInstance upon creation on the publisher side. We need to store server_uris in the MPCInstance to be propagated back to the partner side. Reviewed By: danbunnell, joe1234wu Differential Revision: D40997128 fbshipit-source-id: d3dd2570ac417fe90b5568a3a8dbebfddf93a1f1
YigeZhu
force-pushed
the
export-D40997128
branch
from
November 11, 2022 18:26
44f0288
to
79885d9
Compare
This pull request was exported from Phabricator. Differential Revision: D40997128 |
Summary: Pull Request resolved: facebookresearch#459 As title. server_uris will be passed into MPCInstance upon creation on the publisher side. We need to store server_uris in the MPCInstance to be propagated back to the partner side. Reviewed By: danbunnell, joe1234wu Differential Revision: D40997128 fbshipit-source-id: 68e9d3db324b7297989c853edd7115ffba22e491
YigeZhu
force-pushed
the
export-D40997128
branch
from
November 11, 2022 18:37
79885d9
to
3ab42e4
Compare
This pull request was exported from Phabricator. Differential Revision: D40997128 |
YigeZhu
added a commit
to YigeZhu/fbpcs
that referenced
this pull request
Nov 11, 2022
Summary: X-link: facebookresearch/fbpcp#459 As title. server_uris will be passed into MPCInstance upon creation on the publisher side. We need to store server_uris in the MPCInstance to be propagated back to the partner side. Differential Revision: D40997128 fbshipit-source-id: 22a961d139f36e65543854698a677b72ac773db9
YigeZhu
added a commit
to YigeZhu/fbpcs
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: facebookresearch#1913 X-link: facebookresearch/fbpcp#459 As title. server_uris will be passed into MPCInstance upon creation on the publisher side. We need to store server_uris in the MPCInstance to be propagated back to the partner side. Reviewed By: joe1234wu Differential Revision: D40997128 fbshipit-source-id: f1b1927b777d5ded5c8b75d930fe24bbd2f5a43a
YigeZhu
added a commit
to YigeZhu/fbpcs
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: facebookresearch#1913 X-link: facebookresearch/fbpcp#459 As title. server_uris will be passed into MPCInstance upon creation on the publisher side. We need to store server_uris in the MPCInstance to be propagated back to the partner side. Reviewed By: joe1234wu Differential Revision: D40997128 fbshipit-source-id: bd2e4f0aee6c7278b7cf1249e1e755f0d3d1f782
facebook-github-bot
pushed a commit
to facebookresearch/fbpcs
that referenced
this pull request
Nov 11, 2022
Summary: Pull Request resolved: #1913 X-link: facebookresearch/fbpcp#459 As title. server_uris will be passed into MPCInstance upon creation on the publisher side. We need to store server_uris in the MPCInstance to be propagated back to the partner side. Reviewed By: joe1234wu Differential Revision: D40997128 fbshipit-source-id: 81278015d79676113dfd216001fe8befcdecea71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As title. server_uris will be passed into MPCInstance upon creation on the publisher side. We need to store server_uris in the MPCInstance to be propagated back to the partner side.
Differential Revision: D40997128