Remove partial dependency in PCSContainerService (#405) #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38604420 |
zhuang-93
added a commit
to zhuang-93/fbpcs-1
that referenced
this pull request
Aug 12, 2022
Summary: Pull Request resolved: facebookresearch#1428 X-link: facebookresearch/fbpcp#405 We decided that validate_container_definitions should not be a public API in container service. This diff is to remove partial dependency in PCSContainerService The validation logic has been moved in D38629555, to ensure the backward compatibility, we firstly changed the function body to ``pass``. Differential Revision: D38604420 fbshipit-source-id: fe1f6fb35587ce975f6fce492ec60218facd90fd
zhuang-93
force-pushed
the
export-D38604420
branch
from
b49e1cb to
38e9989
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38604420 |
Summary: Pull Request resolved: facebookresearch#1428 X-link: facebookresearch/fbpcp#405 We decided that validate_container_definitions should not be a public API in container service. This diff is to remove partial dependency in PCSContainerService The validation logic has been moved in D38629555, to ensure the backward compatibility, we firstly changed the function body to ``pass``. Differential Revision: D38604420 fbshipit-source-id: 74e63e0bd150e398b1a427fe35339b9ab0de6b39
zhuang-93
force-pushed
the
export-D38604420
branch
from
38e9989 to
8281764
Compare
|
This pull request was exported from Phabricator. Differential Revision: D38604420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookresearch/fbpcp#405
We decided that validate_container_definitions should not be a public API in container service. This diff is to remove it and resolve the conflict.
The validation logic has been moved in D38629555, to ensure the backward compatibility, we firstly changed the function body to
pass.Differential Revision: D38604420