Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI testing of Python 2.7 on Windows #63

Closed
omry opened this issue Aug 13, 2019 · 6 comments
Closed

Fix CI testing of Python 2.7 on Windows #63

omry opened this issue Aug 13, 2019 · 6 comments
Labels
blocked Can't make progress

Comments

@omry
Copy link
Collaborator

omry commented Aug 13, 2019

https://circleci.com/docs/2.0/hello-world-windows/
@omry omry added this to the Initial OSS release milestone Aug 13, 2019
@omry
Copy link
Collaborator Author

omry commented Aug 15, 2019

work in progress in windows-ci2 branch.

This is blocked on nox not detecting installed python version on Windows in conda because the name is python and not python2 or python3.

@omry omry changed the title Try to integrate with circleci windows build to get windows test coverage Support Windows Aug 17, 2019
omry added a commit that referenced this issue Aug 17, 2019
@omry
Windows compatibility:
a9d06fc 
1. Paths in get_load_history are now normalized to be identical between Windows and Unix
2. override dirname separator changes from : to =
3. Task tests are now shutting down logging to allow the output directory to be deleted

fixes #63
@omry
Copy link
Collaborator Author

omry commented Aug 25, 2019

pushing support for windows contbuild for python 3.6 and 3.7.
Still nox issues with python 2.7.

@omry omry added the In progress Work in progress label Aug 26, 2019
@omry
Copy link
Collaborator Author

omry commented Sep 17, 2019 •
edited
Loading

Waiting on progress in wntrblm/nox#250

@omry omry removed this from the Initial OSS release milestone Sep 28, 2019
@omry omry changed the title Support Windows Fix CI testing of Python 2.7 on Windows Sep 28, 2019
@omry
Copy link
Collaborator Author

omry commented Oct 2, 2019

This is now completely disabled due to https://chocolatey.org/packages/miniconda3#comment-4636661032

@omry
Copy link
Collaborator Author

omry commented Oct 5, 2019

re-enabled for Python 3x.

@omry omry added blocked Can't make progress and removed In progress Work in progress labels Oct 5, 2019
@omry
Copy link
Collaborator Author

omry commented Dec 29, 2019

Python 2.7 is being dropped in the next version of Hydra. this is no longer relevant.

@omry omry closed this as completed Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Can't make progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@omry