Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column gaps set to "columnWidth" do not work with nested grids #16

Open
jacobsfletch opened this issue Oct 14, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@jacobsfletch
Copy link
Member

getColGap is fired in the global grid settings provider, and uses the cols from props. But, nested grids trim cols from the grid as they nest. This means stylesheets need to be injected at every grid, instead of the top-level settings provider, so they can read available cols from context when they are generated.

This would bloat the html, though. So alternatively, we should potentially deprecate columnWidth until css natively supports Subgrid.

@jacobsfletch jacobsfletch added the bug Something isn't working label Oct 14, 2021
@jacobsfletch jacobsfletch changed the title Columns gaps set to "columnWidth" do not work with nested grids Column gaps set to "columnWidth" do not work with nested grids Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant