Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

req() an input to prevent crashing when used in a shiny app #49

Merged
merged 1 commit into from
May 6, 2022
Merged

req() an input to prevent crashing when used in a shiny app #49

merged 1 commit into from
May 6, 2022

Conversation

jonocarroll
Copy link
Collaborator

@jonocarroll jonocarroll commented May 5, 2022 •
edited
Loading

Tests fail, but they failed before, too.

shine() on a fpca result did work, but likely because the UI was generated fast enough. When used in an insertUI() context it's possible to have it be too slow, so a req() of the input helps.

@jonocarroll jonocarroll mentioned this pull request May 5, 2022
Open
@lianos lianos merged commit 4b98b23 into main May 6, 2022
@jonocarroll jonocarroll deleted the bugfix_fpca_req branch May 9, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonocarroll @lianos