Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_assay_data(facilitated, ...) is fishy #3

Open
lianos opened this issue Apr 16, 2020 · 0 comments
Open

fetch_assay_data(facilitated, ...) is fishy #3

lianos opened this issue Apr 16, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lianos
Copy link
Member

lianos commented Apr 16, 2020

The FacileBiocData-inspired FacileAnalysis vignette is doing something very weird here:

dat.bc <- fdds %>% 
  fetch_assay_data(features = head(vm.res, 1),
                   normalized = TRUE,
                   batch = "cell") %>% 
  with_sample_covariates("treatment") %>% 
  mutate(type = "batch_corrected")

If we debug(FacileData::as_facile_frame, you'll be caught in an infinite loop of of as_facile_frame calls ...

@lianos lianos added the bug Something isn't working label Apr 16, 2020
@lianos lianos self-assigned this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant