Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve continuous color maps #7

Open
lianos opened this issue Dec 5, 2019 · 0 comments
Open

Improve continuous color maps #7

lianos opened this issue Dec 5, 2019 · 0 comments
Assignees
@lianos
Labels
enhancement New feature or request

Comments

@lianos
Copy link
Member

lianos commented Dec 5, 2019

The way we handle color mapping (via with_color) doesn't work with plotly.

Not sure how to hand plotly a colorRamp like function, which is in the aes_map(data)$color, so right now (just in fscatterplot), when the color is mapped to a continuous trait, we let plotly do its default thing (use viridis) by not passing anything to the add_markers(colors) parameter.
@lianos lianos added the enhancement New feature or request label Dec 5, 2019
@lianos lianos self-assigned this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lianos lianos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lianos