Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run flake8 and tidy up code #3

Open
pbugnion opened this issue Apr 29, 2018 · 3 comments
Open

Run flake8 and tidy up code #3

pbugnion opened this issue Apr 29, 2018 · 3 comments

Comments

@pbugnion
Copy link
Contributor

Many of the older parts of sml-sync remain embarrassingly untidy. This is a particularly bad because it makes it harder to enforce best practices for new contributions.

We should run flake8 and tidy up anything that comes up.

@pbugnion pbugnion mentioned this issue Apr 29, 2018
@srstevenson
Copy link
Contributor

I'm happy to take this on.

@pbugnion
Copy link
Contributor Author

pbugnion commented May 21, 2018

Thank you! I think that, if we do this, we should add a Travis flake8 check (otherwise we'll just regress).

@srstevenson
Copy link
Contributor

Agreed!

@srstevenson srstevenson removed their assignment Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants