Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Vote for top phrases created by the bot #1

Open
Auralcat opened this issue Mar 26, 2024 · 2 comments
Open

Feature request: Vote for top phrases created by the bot #1

Auralcat opened this issue Mar 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Auralcat
Copy link

Overview

I like talking on IRC in a channel where we use a bot using this codebase. It gathered many words and comes up with funny phrases. Sometimes they are so funny, I feel the need to keep them for posterity.

It would be nice to have a way to vote for the top phrases the bot comes up with. That way we can keep a record of the funniest ones and get a chuckle out of them again.

Since IRC etiquette recommends using links for long pieces of text, the bot could output a link with the top-voted phrases and people could check them out at their convenience. What do you think?

@shombando
Copy link

shombando commented Mar 26, 2024

To add to this feature request a bit and clarify the original ask as discussed on IRC:

  • Clarification: The phrases need to be voted on/nominated as the bot creates them. @Auralcat please let me know if I didn't capture the intent correctly and I added some of my own thoughts too.

    • But a simple !vote type comment right after the bot's comment would be confusing since the bot does trigger almost immediately if a trigger word is encountered. So a vote would need to be tied to a comment ID.
    • If the comment was rendered with the comment that would be helpful so users can just reply with !vote <id> and make the workflow easy.
    • If the comment doesn't show an ID by default then another command like !recent would trigger a list of recent comments and then users can !vote <id>. However, that seems noisy to me and I have a personal bias for bots messages being immediately identifiable so a comment with id serves that personal preferenc as well.
  • Enhancing feature: The phrases that the bot spits out are really funny in context of the triggering comment. So when the top phrases are rendered then the comment that prompted that response should also been shown.

I'm happy to clarify and expound further if you have any questions on my thoughts above. Cheers @fade!

@fade
Copy link
Owner

fade commented Mar 26, 2024

This is a good idea, and I will work on it. There are some complicating factors around what state the bot keeps, and how it keeps it which I will have to work through, but it already exposes a web server for URL indexing, so adding an endpoint as a view into this data should be straight forward.

@fade fade self-assigned this Mar 26, 2024
@fade fade added the enhancement New feature or request label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants