Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitizer Block: Rename "poll_rate" to "poll_duration" or change the used unit #94

Open
alexxcons opened this issue Jan 19, 2022 · 2 comments

Comments

@alexxcons
Copy link
Collaborator

alexxcons commented Jan 19, 2022

poll_rate sounds like a frequency (Hz), but we actually work with seconds.

So either rename the variable to e.g. poll_delay/poll_duration (better names welcome!) or change the used unit to Hz.

In any case, a fix in all used flowgraphs will be requird after this change !

To be fixed in the xml of all Digitizer Blocks and in the C++ classes of these Blocks (class "digitizer_block").

@RalphSteinhagen
Copy link
Member

My two-pence worth:
I'd recommend using `polling_period' since its a unit of time that is used repetitively.
| <- period -> | <- period -> | <- period -> ...

Using 'delay' suggests IMHO that we wait until something is supposed to start or continue.
| delay -> | start doing something

@alexxcons
Copy link
Collaborator Author

Yep, polling_period sounds good to me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants