Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dart's native class for big numbers instead of custom Uint64 #1

Open
fajarvm opened this issue Dec 27, 2019 · 0 comments
Open

Use Dart's native class for big numbers instead of custom Uint64 #1

fajarvm opened this issue Dec 27, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@fajarvm
Copy link
Owner

fajarvm commented Dec 27, 2019

Currently, this project is using its own class Uint64 to deal with big numbers. Dart's core lib has a BigInt class that can be used to work with big numbers.

However, there is currently an issue withBigInt when compiled to JavaScript (via dart2js), integers are therefore restricted to 53 significant bits because all JavaScript numbers are double-precision floating point values.

Please refer to this Dart language documentation page for information regarding big numbers and their known issues.
See also: https://github.com/dart-lang/sdk/blob/master/docs/language/informal/int64.md

When Dart SDK is updated with a BigInt class (or whichever replaces it) that is compatible with dart2js, this project should also be updated to use that class instead of Uint64.

@fajarvm fajarvm added the enhancement New feature or request label Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant