Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch builder images to use gcc images as base for any fallback target #261

Open
FedeDP opened this issue Mar 24, 2023 · 17 comments
Open
Labels
kind/feature New feature or request

Comments

@FedeDP
Copy link
Contributor

FedeDP commented Mar 24, 2023

Motivation

It would be much simpler for us to rely on the official gcc images: https://hub.docker.com/_/gcc.

Feature

Official gcc images are multi platform; support x86_64, arm64, arm32 and s390x.
Moreover, they are official, therefore they won't suddenly disappear.

Using them, we could drop the arch from our builder images regex, as all our builder images would be multiarch.
Moreover, we could cover any gcc version we want; finally, we would also have a single image for each gcc version (no more a single image that provides a list of gcc versions!)

I'd wait for #258 and the PR by Aldo to port the Images listing code from docker client to falcoctl.

WDYT @EXONER4TED @alacuku @Lowaiz @dwindsor ?

@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 24, 2023

Considering that @alacuku will already port the builder images to correctly use a docker repository, in the end we would have: falcosecurity/docker-builder docker repository, with tags like:

  • any_gcc4.9.1-latest
  • any_gcc4.9.1-master
  • any_gcc6.0.0-commithash
  • centos_gcc4.8.5-latest

We will still need to support specific images (ie: images that do not rely on he official gcc ones but instead use distro-specific one, like the driverkit-builder-centos-x86_64_gcc4.8.5) because some drivers absolutely want their distro gcc to build.
Given that we will still support distro-specific images, i am not sure whether we want to retain the architecture field in the builder images regex name, as distro-specific images could be arch-specific.

@FedeDP FedeDP changed the title Switch builder images to use gcc images as base Switch builder images to use gcc images as base for any fallback target Mar 24, 2023
@alacuku
Copy link
Member

alacuku commented Mar 24, 2023

Given that we will still support distro-specific images, i am not sure whether we want to retain the architecture field in the builder images regex name, as distro-specific images could be arch-specific.

How many distros need a distro-specific image?

@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 24, 2023

For now, we only had one case (the aforementioned centos one).
But we cannot tell it in advance unfortunately. Only time will tell!

@poiana
Copy link

poiana commented Jun 22, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 22, 2023

/remove-lifecycle stale

@poiana
Copy link

poiana commented Sep 20, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 20, 2023

/remove-lifecycle stale

@poiana
Copy link

poiana commented Dec 19, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 19, 2023

/remove-lifecycle stale

@poiana
Copy link

poiana commented Mar 18, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 18, 2024

/remove-lifecycle stale

@poiana
Copy link

poiana commented Jun 16, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 17, 2024

/remove-lifecycle stale

@poiana
Copy link

poiana commented Sep 15, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 16, 2024

/remove-lifecycle stale

@poiana
Copy link

poiana commented Dec 15, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 16, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants