Skip to content

Commit 2c795d8

Browse files
committed
fix(falco): allow disable_cri_async from both CLI and config
Signed-off-by: Luca Guerra <[email protected]>
1 parent 50b98b3 commit 2c795d8

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

userspace/falco/app/actions/init_inspectors.cpp

+7-8
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,13 @@ static void init_syscall_inspector(falco::app::state& s, std::shared_ptr<sinsp>
6767
"Enabled container runtime socket at '" + p + "' via config file");
6868
}
6969
}
70-
inspector->set_cri_async(!s.config->m_container_engines_disable_cri_async);
70+
71+
bool disable_cri_async = s.config->m_container_engines_disable_cri_async || s.options.disable_cri_async;
72+
inspector->set_cri_async(!disable_cri_async);
73+
74+
if(disable_cri_async) {
75+
falco_logger::log(falco_logger::level::DEBUG, "Disabling async lookups for 'CRI'");
76+
}
7177

7278
// Container engines configs via CLI args
7379
// If required, set the CRI paths
@@ -79,13 +85,6 @@ static void init_syscall_inspector(falco::app::state& s, std::shared_ptr<sinsp>
7985
}
8086
}
8187

82-
// Decide whether to do sync or async for CRI metadata fetch
83-
inspector->set_cri_async(!s.options.disable_cri_async);
84-
85-
if(s.options.disable_cri_async || s.config->m_container_engines_disable_cri_async) {
86-
falco_logger::log(falco_logger::level::DEBUG, "Disabling async lookups for 'CRI'");
87-
}
88-
8988
//
9089
// If required, set the snaplen
9190
//

0 commit comments

Comments
 (0)