Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Falcoctl notification of rule changes on apply #568

Open
tspearconquest opened this issue Apr 8, 2023 · 15 comments
Open

Comments

@tspearconquest
Copy link

Motivation

When rules are updated by falcoctl, I don't get any notification of what changed. I need visibility into this in order to aid in debugging issues.

Feature

Part of the output from falcoctl should report on which rules changed (possibly additionally showing a diff if provided a flag for it)

Alternatives

Only manually trying to diff them, which is highly error-prone.

Additional context

This could tie into Falco as well fairly easily so that falco emits a Notice or Info level message about the rules changing.

Create a rule to have falco watch for falcoctl to modify the rules. I started trying to craft one but have not tested it: condition: (fd.directory=/etc/falco and fd.name endswith falco_rules.yaml) and evt.dir=< and open_write and proc_name_exists and proc.name=falcoctl

@incertum
Copy link

incertum commented Jul 5, 2023

@jasondellaluce you have a real cool new automation to check on the diff in a PR, what is the delta to support this in falcoctl, thanks!

@incertum
Copy link

incertum commented Jul 5, 2023

/milestone 0.37.0

@LucaGuerra and @jasondellaluce this aligns with the revamped rules maturity and adoption framework and there seem to be more capabilities we need for falcoctl as a result of a new approach to track the maturity of rules, therefore I am assigning a more conservative Falco 0.37 for now.

@poiana
Copy link
Contributor

poiana commented Nov 29, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@tspearconquest
Copy link
Author

Thanks @Andreagit97

@poiana
Copy link
Contributor

poiana commented Feb 28, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented May 29, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Andreagit97
Copy link
Member

/remove-lifecycle stale

@leogr
Copy link
Member

leogr commented May 29, 2024

This should be addressed in falcoctl. So, moving this to its own repo.

cc @falcosecurity/falcoctl-maintainers

@leogr leogr transferred this issue from falcosecurity/falco May 29, 2024
@tspearconquest
Copy link
Author

I missed the later updates, apologies!

@poiana
Copy link
Contributor

poiana commented Aug 27, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Aug 28, 2024

/remove-lifecycle stale

@poiana
Copy link
Contributor

poiana commented Nov 26, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member

leogr commented Dec 10, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants