Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing customfields/extra_fields on Elasticsearch export #1033

Open
qsoul opened this issue Oct 27, 2024 · 4 comments
Open

Missing customfields/extra_fields on Elasticsearch export #1033

qsoul opened this issue Oct 27, 2024 · 4 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@qsoul
Copy link

qsoul commented Oct 27, 2024

Describe the bug

When using falco's append_output.extra_fields or falcosidekick customfields they both appear in falco's output, but are missing when exporting to Elasticsearch (via Elasticsearch output method). Those extra fields just are not present at all in the post request json body.

  • Falco version:
    Falco version: 0.39.1

  • Falcosidekick version:
    Falco version: 2.29.0

  • Installation method:
    Kubernetes (via Helm)

@qsoul qsoul added the kind/bug Something isn't working label Oct 27, 2024
@qsoul qsoul closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
@qsoul qsoul reopened this Oct 27, 2024
@Issif Issif self-assigned this Oct 28, 2024
@Issif Issif added this to the 2.30 milestone Oct 28, 2024
@Issif
Copy link
Member

Issif commented Oct 28, 2024

Hi,

I think I was able to replicate the issue. Can you confirm me that the value elasticsearch.flattenfields is true in your config?

Edit: there's a bug in my code to "flatten" the keys of the output_fields, a check is missing, and the keys without any dot are removed. I'm on the fix right now

@Issif
Copy link
Member

Issif commented Oct 28, 2024

The PR with the fix is https://github.com/falcosecurity/falcosidekick/pull/1034/files, it will be in the next 2.30, sadly I don't have any ETA, but I could generate a release candidate for you if you need.

@qsoul
Copy link
Author

qsoul commented Oct 29, 2024

Hi,

I think I was able to replicate the issue. Can you confirm me that the value elasticsearch.flattenfields is true in your config?

Edit: there's a bug in my code to "flatten" the keys of the output_fields, a check is missing, and the keys without any dot are removed. I'm on the fix right now

Thank you for handling it so fast!
I'll use the lastest image untill the next release. One more thanks!
p.s. I don't use elasticsearch.flattenfields explicitly, but use createindextemplate: true, so yes, that should be same I believe.

@Issif
Copy link
Member

Issif commented Oct 29, 2024

Yes, the createtemplate setting implies it, to avoid conflicts with some fields types that may appear as nested or not, we got multiple issues because of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants