Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Prometheus naming convention for falco_events metric #940

Open
cezkuj opened this issue Jul 3, 2024 · 3 comments
Open

Follow Prometheus naming convention for falco_events metric #940

cezkuj opened this issue Jul 3, 2024 · 3 comments
Assignees
Labels
kind/feature New feature or request
Milestone

Comments

@cezkuj
Copy link

cezkuj commented Jul 3, 2024

Motivation
falco_events metric doesn't follow Prometheus naming convention causing issues with inferring its type in a monitoring system. In our case this is NewRelic Prometheus integration that uses remote write protocol. Metric is by default considered a gauge and needs manual overwrites to change its type to a counter.

Feature

Changing metric name from falco_events to falco_events_total

Additional context

I am aware that changing metric name is a breaking change, but it would be nice to have it changed at some point :)

@cezkuj cezkuj added the kind/feature New feature or request label Jul 3, 2024
@Issif
Copy link
Member

Issif commented Jul 3, 2024

😥 I released the 2.29.0 yesterday.
Falco now exposes a Prometheus endpoint, so I wanted to remove some metrics in sidekick cause they are in double with those in Falco in 2.30. Could be the occasion to do both. I don't have any ETA

@poiana
Copy link

poiana commented Oct 16, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Issif
Copy link
Member

Issif commented Oct 18, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
Status: To do
Development

No branches or pull requests

3 participants