From 9ae98d3ff813eb013d109a35da66b60294ae12ec Mon Sep 17 00:00:00 2001 From: Luca Guerra Date: Mon, 1 Jul 2024 10:49:43 +0000 Subject: [PATCH] chore(libsinsp): fix unused value for fscanf Signed-off-by: Luca Guerra --- userspace/libsinsp/metrics_collector.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/userspace/libsinsp/metrics_collector.cpp b/userspace/libsinsp/metrics_collector.cpp index 0c430034fe..8ed3e0f06b 100644 --- a/userspace/libsinsp/metrics_collector.cpp +++ b/userspace/libsinsp/metrics_collector.cpp @@ -488,7 +488,7 @@ void libs_resource_utilization::get_container_memory_used() if (filepath == nullptr) { // No need for scap_get_host_root since we look at the container pid namespace (if applicable) - // Known collison for VM memory usage, but this default value is configurable + // Known collision for VM memory usage, but this default value is configurable filepath = "/sys/fs/cgroup/memory/memory.usage_in_bytes"; } @@ -499,10 +499,13 @@ void libs_resource_utilization::get_container_memory_used() } /* memory size returned in bytes */ - fscanf(f, "%" SCNu64, &m_container_memory_used); - fclose(f); + int fscanf_matched = fscanf(f, "%" SCNu64, &m_container_memory_used); + if (fscanf_matched != 1) + { + m_container_memory_used = 0; + } - return; + fclose(f); } libs_state_counters::libs_state_counters(std::shared_ptr sinsp_stats_v2, sinsp_thread_manager* thread_manager) : m_sinsp_stats_v2(sinsp_stats_v2), m_n_fds(0), m_n_threads(0) {