Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider specify metrics version for opinionated_metrics #17

Open
Banyc opened this issue Oct 17, 2023 · 0 comments
Open

Consider specify metrics version for opinionated_metrics #17

Banyc opened this issue Oct 17, 2023 · 0 comments

Comments

@Banyc
Copy link

Banyc commented Oct 17, 2023

The latest metrics as of now is 0.21.1, which is not the same as the version opinionated_metrics depends on (that is 0.20.1). The static RECORDERs of the two metrics versions are different instances. If users added the wrong metrics version, counter!() will be sent to the wrong uninitialized RECORDER, instead of being collected by the initiated one.

It will be great if the docs explicitly tell users which metrics version to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant