From febc7837f9640815c6f96f72aca88f1569abcb52 Mon Sep 17 00:00:00 2001 From: Varun Srinivasan Date: Wed, 10 Jul 2024 21:47:28 -0700 Subject: [PATCH] chore: remove unnecessary foundry version pin in ci (#2155) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Why is this change needed? A foundry version was pinned in CI due to [this bug](https://github.com/foundry-rs/foundry/issues/5749). it has been fixed for almost a year now, so we don't need to do this anymore. ## Merge Checklist - [x] PR title adheres to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) standard - [ ] PR has a [changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets) - [x] PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore) - [ ] PR includes [documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs) if necessary. --- ## PR-Codex overview The focus of this PR is to update the installation process in the CI workflow by removing the pinned version of Foundry and installing dependencies with `yarn`. ### Detailed summary - Removed pinned version of Foundry installation in CI workflow - Changed installation of dependencies to use `yarn install` command > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` --- .github/workflows/ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a9d297e6e7..5e816efd0c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -123,9 +123,6 @@ jobs: - name: Install Foundry uses: foundry-rs/foundry-toolchain@v1 - with: - # Pinning until https://github.com/foundry-rs/foundry/issues/5749 is fixed - version: nightly-ca67d15f4abd46394b324c50e21e66f306a1162d - name: Install dependencies run: yarn install