Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 404 links and spelling #2505

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: 404 links and spelling #2505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
316c72b
fix corr 11.fnameIndex.ts
polytur Jan 28, 2025
b405917
404 link EthersV5Eip712Signer.md
polytur Jan 28, 2025
849fcb3
404 link EthersEip712Signer.md
polytur Jan 28, 2025
95a2e15
404 links README.md
polytur Jan 28, 2025
f74527b
404 link ViemLocalEip712Signer.md
polytur Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/hubble/src/storage/db/migrations/11.fnameIndex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { ResultAsync } from "neverthrow";
const log = logger.child({ component: "fnameIndex" });

/**
* Up untill now, we were accidentally writing the fid index for the fname messages as Little Endian
* Up until now, we were accidentally writing the fid index for the fname messages as Little Endian
* instead of Big Endian in name_registry_events.rs:make_fname_username_proof_by_fid_key.
* This migration will fix that to be big endian, and also remove the little endian index keys
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/hub-nodejs/docs/signers/EthersEip712Signer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ if (ethereumAddressResult.isOk()) {

| Name | Type | Description |
| :------ | :------------------------------------------------------------------------------- | :---------------------------------- |
| `claim` | [`VerificationEthAddressClaim`](../modules/types.md#verificationethaddressclaim) | The body of the claim to be signed. |
| `claim` | `VerificationEthAddressClaim` | The body of the claim to be signed. |

---

Expand Down
2 changes: 1 addition & 1 deletion packages/hub-nodejs/docs/signers/EthersV5Eip712Signer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ if (ethereumAddressResult.isOk()) {

| Name | Type | Description |
| :------ | :------------------------------------------------------------------------------- | :---------------------------------- |
| `claim` | [`VerificationEthAddressClaim`](../modules/types.md#verificationethaddressclaim) | The body of the claim to be signed. |
| `claim` | `VerificationEthAddressClaim`| The body of the claim to be signed. |

---

Expand Down
2 changes: 1 addition & 1 deletion packages/hub-nodejs/docs/signers/ViemLocalEip712Signer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ if (ethereumAddressResult.isOk()) {

| Name | Type | Description |
| :------ | :------------------------------------------------------------------------------- | :---------------------------------- |
| `claim` | [`VerificationEthAddressClaim`](../modules/types.md#verificationethaddressclaim) | The body of the claim to be signed. |
| `claim` | `VerificationEthAddressClaim` | The body of the claim to be signed. |

---

Expand Down
4 changes: 1 addition & 3 deletions packages/hub-nodejs/examples/hello-world/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,9 @@ Given a custody address with ~10$ worth of funds on OP Mainnet, this example wil

We do not recommend running this example in a cloud environment because it requires your custody address.

You can try out a web version of this at https://farcaster-signup-demo-wkulikowski.vercel.app. Source: https://github.com/wojtekwtf/farcaster-signup-demo by [@woj.eth](https://warpcast.com/woj.eth).

### Run locally

1. Clone the repo locally
2. Navigate to this folder with `cd packages/hub-nodejs/examples/write-data`
3. Run `yarn install` to install dependencies
4. Run `yarn start`
4. Run `yarn start`