Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in the 11.fnameIndex.ts #2511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

teenager-ETH
Copy link
Contributor

@teenager-ETH teenager-ETH commented Feb 2, 2025

11.fnameIndex.ts: Fixed untilluntil.


PR-Codex overview

This PR addresses a bug in the fname index writing process for fid messages, correcting it from Little Endian to Big Endian format. It also includes a migration to remove the previously used Little Endian index keys.

Detailed summary

  • Corrected the comment spelling from "Up untill" to "Up until".
  • Clarified that the migration fixes the fid index for fname messages to be Big Endian.
  • Added information about the removal of Little Endian index keys.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 2, 2025

⚠️ No Changeset found

Latest commit: 9e85fdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 8:32pm

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.95%. Comparing base (1880070) to head (9e85fdc).
Report is 492 commits behind head on main.

❌ Your project check has failed because the head coverage (34.95%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (1880070) and HEAD (9e85fdc). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1880070) HEAD (9e85fdc)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2511       +/-   ##
===========================================
- Coverage   74.05%   34.95%   -39.11%     
===========================================
  Files          99      146       +47     
  Lines        9425    26283    +16858     
  Branches     2097     9384     +7287     
===========================================
+ Hits         6980     9186     +2206     
- Misses       2327    14469    +12142     
- Partials      118     2628     +2510     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant