Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix misleading test name #2524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

defiberrys
Copy link

@defiberrys defiberrys commented Feb 9, 2025

Why is this change needed?

Noticed that the test was named "fails without fid or tsHash", but it actually only checks for the absence of fid.
Updated the name to "fails without fid" to match the actual behavior.

Merge Checklist


PR-Codex overview

This PR focuses on modifying a test case in the castService.test.ts file to ensure it accurately reflects the validation of the fid parameter.

Detailed summary

  • Changed the test description from "fails without fid or tsHash" to "fails without fid".
  • The test now only checks for the absence of fid when calling client.getCast with fid: 0 and an empty hash, expecting a HubError indicating that "fid is missing".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 9, 2025

⚠️ No Changeset found

Latest commit: 439c67c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 10:44am

@defiberrys
Copy link
Author

sanjayprabhu, pls check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant