Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move conversion methods to wrapper classes #125

Open
5 tasks done
farhan5248 opened this issue Mar 21, 2024 · 17 comments
Open
5 tasks done

Move conversion methods to wrapper classes #125

farhan5248 opened this issue Mar 21, 2024 · 17 comments
Assignees
Labels
maintenance Used for build/test automation and code clean-up/refactoring

Comments

@farhan5248
Copy link
Owner

farhan5248 commented Mar 21, 2024

Interfaces and super classes

  • Move methods from core abstract classes to wrappers and delete any not used. Run all tests up to re-generating all the project tests before deleting anything.
  • make a convertFeature method called by convertObject

Clean up

  • Merge the converter and convert code together
  • Review all the TODO
  • Tag everything
@farhan5248 farhan5248 self-assigned this Mar 21, 2024
@farhan5248 farhan5248 added the maintenance Used for build/test automation and code clean-up/refactoring label Mar 21, 2024
@farhan5248
Copy link
Owner Author

Working on AdocToGraphConverter.
Will probably change the code to build the graph in reverse.
Start with last abstract scenario and do background last
Start with last step for each abstract scenario.
Start with the last row's last cell and end with the first row's first cell.

@farhan5248
Copy link
Owner Author

Doing things in reverse was a bad idea, will rollback some of those changes, handle backgrounds differently and continue this work

@farhan5248
Copy link
Owner Author

Everything in adoc to graph converter is done except for steps.
Need to change how steps are added and rename as I go along.

@farhan5248
Copy link
Owner Author

Almost done with AdocToGraphConverter
Should work on TODO for createDocString and createDataTable in JGraphTGraphWrapper.
Need to make createDataTableCell and createStepAttribute
Also need to use addLastCoveredEdge

@farhan5248
Copy link
Owner Author

Working on GraphToAdocConverter now

@farhan5248
Copy link
Owner Author

farhan5248 commented Mar 25, 2024

TODO

  • data tables
  • Scenario
  • Scenario Outline
  • put the docstring/datatable label on the edge

@farhan5248
Copy link
Owner Author

Working on GraphToUMLConverter, just have to run tests and fix issues.

@farhan5248
Copy link
Owner Author

Next is UMLToGraphConverter

@farhan5248
Copy link
Owner Author

Will do CodeToUML next

@farhan5248
Copy link
Owner Author

farhan5248 commented Mar 29, 2024

  • remove java converters from the list, they won't be needed eventually
  • read class like stepobj in convertStep or convertDocString
  • read the methods only if there are no interactions to avoid re-reading the file
  • add the step def step and step obj datatable/docstring/status
  • delete the java converters

@farhan5248 farhan5248 changed the title Move private helper methods to wrapper classes Move conversion methods to wrapper classes Apr 1, 2024
@farhan5248
Copy link
Owner Author

All new code added. Will need to review and update tests and then start changes in the description

@farhan5248
Copy link
Owner Author

mbt-transformer tests pass.
mbt-maven-plugin tests are failing, will fix those later

@farhan5248
Copy link
Owner Author

CaseUtils is creating too many changes.
Remove it and revert back to the delimit and capitalize method.

@farhan5248
Copy link
Owner Author

farhan5248 commented Apr 4, 2024

  • rename validator, strip out capitalize etc
  • make get package, factory, interface, stepdefmethod, stepobjmethod
  • get section doesn't need section type
  • stepobjname doesn't need section type
  • stepobjname takes field, modality, section
  • package name is lower case
  • delete getSectionArgument, it should be handled in addStatement
  • delete getStepName, it's only used in one place
  • make createStepForStepObj and createStepForStepDef
  • Make one addStatement that handles Factory and interface names in one spot, everything else passes in the call such as setComponent or setPath and adds section if it's not blank

@farhan5248
Copy link
Owner Author

Test with mbt-maven-plugin, then regenerate all the test code

@farhan5248
Copy link
Owner Author

Regenerated automation
. parameters for interfaces and glue code are being added more than once
. package declaration doesn't match package folder for objects, it does for step defs

@farhan5248
Copy link
Owner Author

Everything has been re-generated and tested, though some steps still don't get picked up and as a result code gets deleted, will need to figure that out eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Used for build/test automation and code clean-up/refactoring
Projects
None yet
Development

No branches or pull requests

1 participant