[FAI-13685] Write config/catalog files #97
Merged
+192
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeniii
requested review from
cjwooo,
tovbinm,
ypc-faros and
willmarks
as code owners
jeniii
commented
Nov 20, 2024
| expect(existsSync(`${tmpDirPath}/state.json`)).toBe(true); | ||
| expect(readFileSync(`${tmpDirPath}/state.json`, 'utf8')).toBe('{}'); | ||
| }); | ||
| describe('loadStateFile', () => { |
There was a problem hiding this comment.
didn't change these tests. just wrap it in another describe
| logger.debug(`Airbyte config files written to: ${srcConfigFilePath}, ${dstConfigFilePath}`); | ||
|
|
||
| // write catalog to temporary directory catalog files | ||
| // TODO: @FAI-14134 Discover catalog |
There was a problem hiding this comment.
discover catalog will be covered in another ticket as we need to spin up docker
|
cjwooo
reviewed
Nov 20, 2024
| airbyteConfig.src.catalog && | ||
| Object.keys(airbyteConfig.src.catalog).length > 0 | ||
| ) { | ||
| airbyteConfig.dst.catalog = airbyteConfig.src.catalog; |
There was a problem hiding this comment.
This is ok for now, but be prepared for logic generate a destination-compatible catalog based on the src catalog. It has slightly different format.
There was a problem hiding this comment.
ohhhh i see. thanks for the heads up
cjwooo
approved these changes
Nov 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
discover catalog and redact secrets will be covered in another ticket
Type of change