-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't seem to work with angular #7
Comments
Or, doesn't work with dynamically injected image elements. |
dynamically injected image elements are already non-blocking images and so there's no need to lazyload them. But if you still want to lazyload them you can call See this discussion: vvo#42 |
@vvo There are some use cases where dynamically injected non blocking images would still want to be lazy loaded. I am also using Angular and loading lots of images with the Flickr API. I only have a certain amount of bandwidth that I am allowed to use. In this case I do not want to load 500 images just because they are "non blocking". I'm sure other people that host their own assets do want to to pay to serve up images unnecessarily. |
@neptunian @ericandrewlewis Good point. @neptunian Can you create a http://jsfiddle.net/ example using angular so we can both work on it? I am sure there's an easy solution, just start an example we can both work on. |
@vvo have you seen this lib: https://github.com/dinbror/blazy |
@neptunian I see, that's handy. As for But it would mean refactoring the library heavily. Because right now it's just one function. As the needed behavior is already feasible, without modifying the library. I don't see this as a big threat. Try it, try to create a jsfiddle, the current API can do what you want. It is not as magic as blazy, I understand. |
One very important note, the way blazy works is by asking the DOM for images to load. While It's a very different design, |
No description provided.
The text was updated successfully, but these errors were encountered: