-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://codesigning.guide/ out of date #795
Comments
Hm, the content of codesigning.guide doesn't seem to come from any of the existing repositories in the fastlane org. @joshdholtz Do you know where this comes from? |
@janpio it appears to be a private repo that core contributors now have access to. I will need to verify if we can make it public. |
This is now public: https://github.com/fastlane/codesigning.guide Does it make sense to fix this in a PR over there, is there anyone to approve & merge? |
If you end up creating a PR, tag me @janbrasna 🤗 I can't promise how quickly I'll get to it, but I'll for sure get to it at some point 🙇 |
@rogerluan Aight, the changeset: fastlane/codesigning.guide#2 (I'm also looking into removing all the superfluous JS & turning that into details-summary html5 instead while at it…) The issue, not related to this particular bit, is both docs.fastlane.tools and codesigning.guide show all the same animated gifs demonsrating examples, and there you can still see the og commands — i.e. unless someone has the bandwidth to redo all the terminal animations showing superseded cli commands, they will be kinda misleading/wrong on both sites fwiw (ex: https://docs.fastlane.tools/actions/match/#usage : …) |
https://codesigning.guide/ still tells you to use
match init
instead offastlane match init
which will lead to either the command not being found or possibly a old-ruby-version warning being raised.The docs on match (https://github.com/fastlane/docs/blob/master/docs/actions/match.md) are up to date, but following along the codesigning intro https://docs.fastlane.tools/codesigning/getting-started/ and clicking on the
codesigning guide
link will lead you down to using the wrong command, without any warning messages telling you to usefastlane match
instead (like when installen match via Gemfile&bundler)The text was updated successfully, but these errors were encountered: