Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate onnx.compose as a potential MergeONNXModels replacement #160

Open
maltanar opened this issue Dec 15, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@maltanar
Copy link
Collaborator

Details

For merging models https://onnx.ai/onnx/api/compose.html also exists and we should consider making the MergeONNXModels transform in QONNX a wrapper for onnx.compose instead, provided that we get the same functionality.

New behavior

MergeONNXModels behaves as before, but internally calls onnx.compose to do the model merging. It may still be necessary to copy and merge other fields we make use of in QONNX, such as tensor annotations.

Motivation

This would mean maintaining less code as part of QONNX which would be desirable.

Parts of QONNX being affected

The MergeONNXModels transformation.

@maltanar maltanar added the enhancement New feature or request label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant