We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://tools.ietf.org/html/rfc6376#section-3.2 states:
Tags with duplicate names MUST NOT occur within a single tag-list; if a tag name does occur more than once, the entire tag-list is invalid.
Suggestion:
diff --git a/lib/Mail/DKIM/KeyValueList.pm b/lib/Mail/DKIM/KeyValueList.pm index 0d98574..1c33fe9 100644 --- a/lib/Mail/DKIM/KeyValueList.pm +++ b/lib/Mail/DKIM/KeyValueList.pm @@ -50 +50,6 @@ sub parse { - $self->{tags_by_name}->{$tagname} = $tag; + if (defined $self->{tags_by_name}->{$tagname}) { + # https://tools.ietf.org/html/rfc6376#section-3.2 + croak 'reused tag name'; + } else { + $self->{tags_by_name}->{$tagname} = $tag; + }
The text was updated successfully, but these errors were encountered:
Any ETA when this might be resolved? Will it help if I created a pull request?
Sorry, something went wrong.
yes, please create a pull request. Thanks.
Merge pull request #13 from bigio/weaver-prereqs
4ef0631
Add missing Author prerequisite
marcbradshaw
No branches or pull requests
https://tools.ietf.org/html/rfc6376#section-3.2 states:
Suggestion:
The text was updated successfully, but these errors were encountered: