jUpgradeMenuTypes::setDestinationData() error handling is buggy

[mahagr]

$table isn't defined in here:

protected function setDestinationData()
{
    // Truncate jupgrade_menus table
    $this->cleanDestinationData();

    if (parent::setDestinationData()) {
        echo JError::raiseError(500, $table->getError());
    }
}

[fastslack]

What file are you talking?

If you check the setDestinationData() from jupgrade.class.php file you can see that the table are setted:

        $table = empty($this->destination) ? $this->source : $this->destination;

[mahagr]

Class is jUpgradeMenuTypes, so the file is migrate_menus.php. Check above function -- there's no $table defined in it.

[fastslack]

Ahh you are right, fixing it.

[fastslack]

You are right i need to do a better error handling in the entire component, i ll do that change in 2.5.2.
For now bf20f3f