Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully deprecate acl_in #3492

Open
mab68 opened this issue Mar 17, 2020 · 1 comment
Open

Fully deprecate acl_in #3492

mab68 opened this issue Mar 17, 2020 · 1 comment
Labels
cleanup non critical cleanup/remove tech debt
Milestone
faucet 1.10.0

Comments

@mab68
Copy link
Contributor

mab68 commented Mar 17, 2020

acl_in is hinted at being deprecated here

faucet/tests/unit/faucet/test_config.py

Line 46 in f13396a

# TODO: Check acls_in work now acl_in is deprecated
& here

faucet/tests/unit/faucet/test_check_config.py

Line 56 in bbe3246

# TODO: Check acls_in work now acl_in is deprecated, remove in future

But it is still considered valid.
Maybe finally deprecate acl_in in 1.10.0?
@mab68 mab68 mentioned this issue Mar 17, 2020
Open
61 tasks
@gizmoguy gizmoguy added this to the faucet 1.10.0 milestone Mar 17, 2020
@gizmoguy
Copy link
Member

Oooohhhh I remember this. We held a faucet hackathon at NZNOG 2018 and @rsanger wrote us a nice acls_in implementation and we totally forgot to remove acl_in.

+faucet 1.10.0

Reference: 64cd24e

@anarkiwi anarkiwi added the cleanup non critical cleanup/remove tech debt label Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup non critical cleanup/remove tech debt
Projects
None yet
Milestone
faucet 1.10.0
Development

No branches or pull requests
3 participants
@gizmoguy @anarkiwi @mab68