Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline_value and baseline_tolerance are not being validated #345

Open
noursaidi opened this issue Jun 1, 2022 · 0 comments
Open

baseline_value and baseline_tolerance are not being validated #345

noursaidi opened this issue Jun 1, 2022 · 0 comments

Comments

@noursaidi
Copy link
Collaborator

The baseline_value and baseline_tolerance in metadata are not being validated. For example,

I have the following metadata (partial):

"pointset": {
    "points": {
      "filter_alarm_pressure_status": {
        "units": "No-units",
        "ref": "BV11.present_value"
      },
      "filter_differential_pressure_sensor": {
        "units": "Degrees-Celsius",
        "ref": "AV12.present_value",
        "baseline_value": 10,
        "baseline_tolerance": 2
      },
      "filter_differential_pressure_setpoint": {
        "units": "Bars",
        "writable": true,
        "baseline_value": 98
      }
    }

I receive the following payload

{
  "points" : {
    "filter_alarm_pressure_status" : {
      "present_value" : false
    },
    "filter_differential_pressure_setpoint" : {
      "present_value" : 98
    },
    "filter_differential_pressure_sensor" : {
      "present_value" : 29
    }
  },
  "timestamp" : "2022-06-01T13:09:58Z",
  "version" : "1.3.14"
}

And I receive no validation errors. My expectation is that there is an error, and perhaps the devices grouped into a baseline out of bounds group or similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant