From 4ecf073eea5c95ceb610578d877ab74647950a15 Mon Sep 17 00:00:00 2001 From: favonia Date: Tue, 24 Oct 2023 12:14:02 -0500 Subject: [PATCH] docs: update comments about Uptime Kuma (#625) --- internal/monitor/uptimekuma.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/internal/monitor/uptimekuma.go b/internal/monitor/uptimekuma.go index 7f65ffe8..48c869a3 100644 --- a/internal/monitor/uptimekuma.go +++ b/internal/monitor/uptimekuma.go @@ -163,8 +163,11 @@ func (h *UptimeKuma) Start(ctx context.Context, ppfmt pp.PP, _message string) bo // Failure pings the server with status=down. func (h *UptimeKuma) Failure(ctx context.Context, ppfmt pp.PP, message string) bool { if len(message) == 0 { - // Uptime Kuma seems to keep the previous message (even if it was for success) by default. - // We thus send an explicit message to overwrite it. + // If we do not send a non-empty message to Uptime Kuma, it seems to + // either keep the previous message (even if it was for success) or + // assume the message is "OK". Either is bad. + // + // We can send a non-empty message to overwrite it. message = "Failing" } return h.ping(ctx, ppfmt, UptimeKumaRequest{Status: "down", Msg: message, Ping: ""})