Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiscript.js removes the ending punctuations. #43

Open
GibreelAbdullah opened this issue Jan 21, 2023 · 4 comments
Open

apiscript.js removes the ending punctuations. #43

GibreelAbdullah opened this issue Jan 21, 2023 · 4 comments

Comments

@GibreelAbdullah
Copy link
Contributor

Noticed that the database/line-by-line is missing all the ending punctuations in English translation (Didn't check them in others). I manually added them in one file (eng-malik) and regenerated the data using apiscript update command.

The manually added punctuation was removed when the updated file was created in line-by-line folder.

@fawazahmed0
Copy link
Owner

fawazahmed0 commented Jan 21, 2023

Yeah, actually the clean up is happening here, specifically this line .
The above code was taken from quran-api

This could be fixed using Unicode property escapes (i.e using something like \P{P} which will ignore puntuations).

Could you share me the file with punctuation?

@GibreelAbdullah
Copy link
Contributor Author

I just added a full stop (.) at the end of hadith 1 of eng-malik to verify.

@GibreelAbdullah
Copy link
Contributor Author

I would like to connect with you @fawazahmed0 . If you are ok kindly message me on telegram https://t.me/GibreelAbdullah

@fawazahmed0
Copy link
Owner

fawazahmed0 commented Jan 22, 2023

Brother, I don't regularly use telegram etc. But I do use my email regularly.

Anyways, the original files with puntuations, dots etc should be available at here and malik is here.

After fixing this issue the files needs to be regenerated and inshallah will look into this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants