LocationAttachment fix

[darylkell]

Fix for locations where address is provided instead of GPS co-ords (issue #392)

• Add self.location attribute to class LocationAttachment to house address string
• Fix for graphql_to_extensible_attachment(a) to include location attribute for addresses, while maintaining current lat/long attributes

[darylkell]

I can see the black lint check failed, and I have seen on a previous PR that this is requested to be fixed by referring to 'CONTRIBUTING.rst' which to be honest is not a guide at all.

As mentioned 20 days ago by madsmtm in a PR, the use of flint has indeed increased the initial difficulty of manual installation (users have to learn a new tool) and unfortunately I can't help any more than provide what I have in this initial PR.

Anyway, I hope it helps.

[kapi2289]

Please run this in your fbchat directory

$ pip install -U black
$ black .

I would change the location attribute name to address.
And please mention in the attribute docs that available are only the coordinates OR only the address

[darylkell]

LocationAttachment attribute 'address' renamed.

[madsmtm]

I'm sorry you're having trouble with flit and black, they're mostly tools to increase my own productivity, but perhaps just as much my own little "political push" towards a better Python development infrastructure 😉. Anyhow, if you'd like to discuss the decision further, I truly encourage you to open an issue about it, this project is probably seen by a lot of beginners, and I'd hate to loose valueable contributions! 😊 (Also, regarding CONTRIBUTING.rst, I'll gladly admit that I'm terrible at writing documentation, if you've got suggestions for improval, then I'm open for criticism!)

Thanks for the PR though, I have a few small nitpicks, but otherwise it looks fine 👍

[darylkell]

I'm happy for you to do whatever you like with the code I've presented to make it viable for your project. I've had a crack at using GitHub to fork/push request etc and learned a bit trying to contribute to FBchat - and I appreciate you bearing with me along the way.
That said, I'm not bothered by having a successful PR contribution next to my name, just wanted to offer a means to improve the API so perhaps you can find some use from what I've added here.

[madsmtm]

LGMT, thanks for the help, i appreciate the effort 👍